Followup to fix the signature ToDOMAnimatedRect

RESOLVED FIXED in mozilla24

Status

()

Product:
Core
Component:
DOM
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

Version:
Trunk
Target:
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

patch
11.53 KB, patch
baku
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
Follow up Bug 866796 comment 15
(Assignee)

Comment 1

•
5 years ago 
Created attachment 749851 [details] [diff] [review]
patch
Attachment #749851 - Flags: review?(Ms2ger)

Comment 2

•
5 years ago 
Sorry, I should have been clearer. I want the function to return an already_AddRefed instead of using an outparam; the name doesn't really bother me.
(Assignee)

Comment 3

•
5 years ago 
Created attachment 751486 [details] [diff] [review]
patch
Attachment #749851 - Attachment is obsolete: true
Attachment #749851 - Flags: review?(Ms2ger)
Attachment #751486 - Flags: review?(Ms2ger)

Comment 4

•
5 years ago 
Comment on attachment 751486 [details] [diff] [review]
patch

Review of attachment 751486 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: content/svg/content/src/nsSVGViewBox.cpp
@@ +196,5 @@
>    aValue.Assign(buf);
>  }
>  
> +
> +already_AddRefed<mozilla::dom::SVGAnimatedRect>

Can you drop the mozilla::?

@@ +211,3 @@
>  }
>  
> +already_AddRefed<mozilla::dom::SVGIRect>

Ditto

@@ +223,5 @@
>      domBaseVal = new DOMBaseVal(this, aSVGElement);
>      sBaseSVGViewBoxTearoffTable.AddTearoff(this, domBaseVal);
>    }
>  
> + return  domBaseVal.forget();

Spacing is off

@@ +231,5 @@
>  {
>    sBaseSVGViewBoxTearoffTable.RemoveTearoff(mVal);
>  }
>  
> +already_AddRefed<mozilla::dom::SVGIRect>

As before
Attachment #751486 - Flags: review?(Ms2ger) → review+
 (Assignee)

Updated

•
5 years ago
Keywords: checkin-needed

Comment 7

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/d48112a83fb2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.