Closed
Bug 871551
Opened 9 years ago
Closed 9 years ago
Followup to fix the signature ToDOMAnimatedRect
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file, 2 obsolete files)
11.53 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Follow up Bug 866796 comment 15
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #749851 -
Flags: review?(Ms2ger)
Comment 2•9 years ago
|
||
Sorry, I should have been clearer. I want the function to return an already_AddRefed instead of using an outparam; the name doesn't really bother me.
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #749851 -
Attachment is obsolete: true
Attachment #749851 -
Flags: review?(Ms2ger)
Attachment #751486 -
Flags: review?(Ms2ger)
Comment 4•9 years ago
|
||
Comment on attachment 751486 [details] [diff] [review] patch Review of attachment 751486 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: content/svg/content/src/nsSVGViewBox.cpp @@ +196,5 @@ > aValue.Assign(buf); > } > > + > +already_AddRefed<mozilla::dom::SVGAnimatedRect> Can you drop the mozilla::? @@ +211,3 @@ > } > > +already_AddRefed<mozilla::dom::SVGIRect> Ditto @@ +223,5 @@ > domBaseVal = new DOMBaseVal(this, aSVGElement); > sBaseSVGViewBoxTearoffTable.AddTearoff(this, domBaseVal); > } > > + return domBaseVal.forget(); Spacing is off @@ +231,5 @@ > { > sBaseSVGViewBoxTearoffTable.RemoveTearoff(mVal); > } > > +already_AddRefed<mozilla::dom::SVGIRect> As before
Attachment #751486 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=81d01401bfc4
Attachment #751486 -
Attachment is obsolete: true
Attachment #751514 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d48112a83fb2
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d48112a83fb2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Updated•3 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•