871551 - Followup to fix the signature ToDOMAnimatedRect

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Follow up Bug 866796 comment 15

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Sorry, I should have been clearer. I want the function to return an already_AddRefed instead of using an outparam; the name doesn't really bother me.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 751486 [details] [diff] [review]
patch

Review of attachment 751486 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: content/svg/content/src/nsSVGViewBox.cpp
@@ +196,5 @@
>    aValue.Assign(buf);
>  }
>  
> +
> +already_AddRefed<mozilla::dom::SVGAnimatedRect>

Can you drop the mozilla::?

@@ +211,3 @@
>  }
>  
> +already_AddRefed<mozilla::dom::SVGIRect>

Ditto

@@ +223,5 @@
>      domBaseVal = new DOMBaseVal(this, aSVGElement);
>      sBaseSVGViewBoxTearoffTable.AddTearoff(this, domBaseVal);
>    }
>  
> + return  domBaseVal.forget();

Spacing is off

@@ +231,5 @@
>  {
>    sBaseSVGViewBoxTearoffTable.RemoveTearoff(mVal);
>  }
>  
> +already_AddRefed<mozilla::dom::SVGIRect>

As before

Comment 5

[Andrea Marchesini [:baku]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=81d01401bfc4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d48112a83fb2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d48112a83fb2