871586 - Can't enable android compatibility for a packaged app

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Wil Clouser [:clouserw]]

Attachment: screenshot

1) Load https://marketplace.firefox.com/developers/app/kitchensink/payments/
2) See the attached screenshot
3) Try to click the platform buttons

If you load a URL like that on -dev there are checkboxes under the platforms and you can enable them.  In prod clicking the buttons does nothing.

Comment 1

[Andrew Williamson [:eviljeff]]

its a packaged app btw - there are no other platforms.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Yeah, you can't change platform compatibility. Bad design? Maybe. But buchets will fix everything I hear!

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Huh, how is this a regression?

Comment 4

[Andrew Williamson [:eviljeff]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #2)
> Yeah, you can't change platform compatibility. Bad design? Maybe. But
> buchets will fix everything I hear!

what would you change it to?  Its a packaged app.  It only supports FirefoxOS.

Comment 5

[Andrew Williamson [:eviljeff]]

here is a non-packaged app for comparison:

https://marketplace.firefox.com/developers/app/wikipedia/payments/

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to Andrew Williamson [:eviljeff] from comment #4)
> (In reply to Christopher Van Wiemeersch [:cvan] from comment #2)
> > Yeah, you can't change platform compatibility. Bad design? Maybe. But
> > buchets will fix everything I hear!
> 
> what would you change it to?  Its a packaged app.  It only supports
> FirefoxOS.

Right, well Android support is here but not ready. I meant going forward we need to be able to allow packaged app to be supported on Android as well.

Comment 7

[Andrew Williamson [:eviljeff]]

(In reply to Wil Clouser [:clouserw] from comment #0)
> Created attachment 748853 [details]
> screenshot
> 
> 1) Load https://marketplace.firefox.com/developers/app/kitchensink/payments/
> 2) See the attached screenshot
> 3) Try to click the platform buttons
> 
> If you load a URL like that on -dev there are checkboxes under the platforms
> and you can enable them.  In prod clicking the buttons does nothing.

on dev there aren't checkboxes for packaged apps either:
https://marketplace-dev.allizom.org/developers/app/kitchensink/payments/

Comment 8

[krupa raj[:krupa]]

Whoops! I didn't realize it was a packaged app. Sorry.

Comment 9

[Bill Walker [:bwalker] [@wfwalker]]

Please allow marketplace installation of packaged apps on Android. Even though support there is not perfect, we need to test it using marketplace. At least can we support it on marketplace-dev?

Comment 10

[Andrew Williamson [:eviljeff]]

My preference would be for it to be waffled off on prod until Android officially supports packaged apps to not confuse developers into believing it will work.  Though I don't know how 'finished' support is at the moment - its not made it to Aurora I take it?

Comment 11

[Bill Walker [:bwalker] [@wfwalker]]

(In reply to Andrew Williamson [:eviljeff] from comment #10)
> My preference would be for it to be waffled off on prod until Android
> officially supports packaged apps to not confuse developers into believing
> it will work.  Though I don't know how 'finished' support is at the moment -
> its not made it to Aurora I take it?

Andrew, see bug 813736. It should just now be in Aurora.

Comment 12

[Wil Clouser [:clouserw]]

Let's make this a waffle flag that we can turn on for individuals or groups?

Comment 13

[Matt Basta [:basta]]

https://github.com/mozilla/zamboni/commit/59272e6b482f573b53022ce0846ef8972ac74d19
https://github.com/mozilla/zamboni/commit/99d4a64f9b8e4e69cda360a258d0d3a0884debb8
https://github.com/mozilla/zamboni/commit/7419bc876cfc0791063a0ee7616295f3ce97e33a
https://github.com/mozilla/zamboni/commit/2ca11ac61fd420ee1dbea7afebb691753340abc2

Comment 14

[Wil Clouser [:clouserw]]

are there waffles we need to add people to?

Comment 15

[Matt Basta [:basta]]

There's really no need to waffle it. We allow installation of packaged apps on any platform that can a.) see the app and b.) use mozApps.installPackage. It would also require adding a lot of logic to waffle, since turning support on for FXOS alone required quite a bit of special casing. The patch was basically to remove all of the special logic.

The worst that would ever happen is a user would visit a packaged app marked as Android compatible on FX for Android stable and not be able to install it. Based on the very low number of packaged apps to begin with, I doubt this will be a problem. Changing platforms also flags an app for rereview.

Comment 16

[Bill Walker [:bwalker] [@wfwalker]]

(In reply to Wil Clouser [:clouserw] from comment #14)
> are there waffles we need to add people to?

Wil, please add James Hugman and Martyn Haigh to the waffle flag for this

Comment 17

[Wil Clouser [:clouserw]]

(In reply to Bill Walker [:bwalker] [@wfwalker] from comment #16)
> (In reply to Wil Clouser [:clouserw] from comment #14)
> > are there waffles we need to add people to?
> 
> Wil, please add James Hugman and Martyn Haigh to the waffle flag for this

Talked on IRC, there isn't anything to add a person to.  Turns out the confusion is that android apps aren't showing up in search.