Closed Bug 871639 Opened 6 years ago Closed 6 years ago

Incorrect title when leaving editing mode while on about:home

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: lucasr, Assigned: Margaret)

References

Details

(Whiteboard: fixed-fig)

Attachments

(1 file, 1 obsolete file)

While on about:home, tapping the AwesomeBar, entering text, then clicking back doesn't restore the title.
Assignee: nobody → margaret.leibovic
Attached patch patch (obsolete) — Splinter Review
Attachment #750737 - Flags: review?(wjohnston)
Comment on attachment 750737 [details] [diff] [review]
patch

Review of attachment 750737 [details] [diff] [review]:
-----------------------------------------------------------------

I don't love passing boolean parameters where its not clear at a glance what they do (but I'm as guilty of it as anyone). Maybe we could create two public methods:

String cancelEdit() { return stopEditing(); }
String commitEdit() {
  String url = stopEditing();
  if (!TextUtils.isEmpty(url))
    setTitle(url);
  return url;
}
Attachment #750737 - Flags: review?(wjohnston) → review+
Attached patch patch v2Splinter Review
That suggestion sounds good to me.
Attachment #750737 - Attachment is obsolete: true
Attachment #751124 - Flags: review?(wjohnston)
Attachment #751124 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/72ad7246f041
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.