871700 - Add MakeAPI Tag support to Popcorn Maker

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Chris DeCairos (:cade)]

Mostly, this ticket will be to get the behind the scenes code working, with less of a focus on a perfect UI. we'll iterate on that.

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/7

WIP Patch - https://github.com/mozilla/popcorn.webmaker.org/pull/7

Comment 2

[Chris DeCairos (:cade)]

This is working quite well, just waiting on Bug 863873 and all the WebFaker tools to land.

I hope to start pushing the latest tools to staging tomorrow to see if they play as nicely as they do locally :D

Comment 3

[Brett Gaylor [:brett]]

Great - status?

Comment 4

[Chris DeCairos (:cade)]

Comment on attachment 750014 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/7

This is working, but the travis build is failing due to issues with the tests and mySQL: in bug 873597

Comment 5

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/66

MakeAPI Fix for duplicate tags

Comment 6

[Matthew Schranz [:mjschranz]]

Comment on attachment 755545 [details] [review]
https://github.com/mozilla/MakeAPI/pull/66

Land this patch plus retag/publish MakeAPI!

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/b56801d27f75534a49bb2661b89193f7228d8677
Bug 871700 - filter out duplicate tags

Comment 8

[Chris DeCairos (:cade)]

Attachment: https://github.com/cadecairos/MakeAPI/tree/bug871700-2

This was all wrong, and got over complicated. no special handling needed for tags/arrays.

Comment 9

[Chris DeCairos (:cade)]

Comment on attachment 755581 [details]
https://github.com/cadecairos/MakeAPI/tree/bug871700-2

I'm gonna sit on this one for a bit

Comment 10

[Chris DeCairos (:cade)]

Comment on attachment 750014 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/7

Okay, one step closer.

Comment 11

[Chris DeCairos (:cade)]

Comment on attachment 755581 [details]
https://github.com/cadecairos/MakeAPI/tree/bug871700-2

We don't need this here.

Comment 12

[David Humphrey (:humph)]

Comment on attachment 750014 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/7

A couple issues in the PR.  r+ from me with those fixed.  I'll be glad to have Matt sign off on this, too.

Comment 13

[Matthew Schranz [:mjschranz]]

Comment on attachment 750014 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/7

Review comments.

When I add a tag "stuff" and then did a search for it with the search page ( all local instances ) I found no records.

Comment 14

[Chris DeCairos (:cade)]

Comment on attachment 750014 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/7

Updated.

Matt: it works fine for me. on the local search page make sure you aren't pointing at makeapi.mofostaging (it's the default value)

Comment 15

[Matthew Schranz [:mjschranz]]

Comment on attachment 750014 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/7

Not sure why I couldn't search on my own tags locally before since I did check against my local server.

Anyway, R+ and file a bug for the test fails and assign to yourself.

Comment 16

[Chris DeCairos (:cade)]

Filed Bug 877772 against the test failures.

Comment 17

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/65f9c98f18a27ecac5db04ba9086fbe93b941fed
Fix Bug 871700 - Basic tag support for Popcorn Maker projects