Closed
Bug 871744
Opened 11 years ago
Closed 11 years ago
Update Firefox logo on Mozilla.org
Categories
(www.mozilla.org :: Pages & Content, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: malexis, Unassigned)
References
Details
(Whiteboard: r=117651,117813)
Attachments
(2 files)
7.34 MB,
application/zip
|
Details | |
133.84 KB,
patch
|
pmac
:
review+
|
Details | Diff | Splinter Review |
Tracking bug for updating the firefox logo on Mozilla.org Go live date July 12 (FFOS launch)
Updated•11 years ago
|
Priority: -- → P3
Comment 1•11 years ago
|
||
A quick update: I've been working through the bedrock site, the old svn-based mozilla.org pages, and the old svn-based .com pages. I'm turning over lots of rocks and discovering bits and pieces of the site long forgotten. Filing bugs for obsolete content as I go. I've got an inventory of the logo use on the Bedrock site, the old svn .org pages, and I'm now working on the old svn .com pages.
Comment 2•11 years ago
|
||
Awesome, thanks Steven!
Comment 3•11 years ago
|
||
Here's the inventory I've been working on: https://docs.google.com/spreadsheet/ccc?key=0Au9T8KeO2UcLdEhUdEVIdC15eWRxdmF2UnNKdmRkUlE&usp=sharing Could I have some mozilla folk run through the three tabs and confirm which pages should be updated with the new logo, and which pages should be dealt with in other ways (deleted, redirected, etc.)?
Comment 4•11 years ago
|
||
Thanks, Steven. I'll take a look today.
Comment 5•11 years ago
|
||
Attaching the logo here for reference.
Comment 6•11 years ago
|
||
I see the files provided do not include the copyright (c) symbol. Should they? Is it needed?
Comment 7•11 years ago
|
||
(In reply to Steven Garrity [:sgarrity] from comment #6) > I see the files provided do not include the copyright (c) symbol. Should > they? Is it needed? Adding Jishnu and Pete for thoughts on the above. Does the new logo need a copyright or registered trademark symbol?
Comment 8•11 years ago
|
||
Hi Steven- Looking at the existing logo and wordmark files on the style guide (http://www.mozilla.org/en-US/styleguide/identity/firefox/wordmarks/), they have the (r) but not the (c), just like the new files provided. Let's move forward with adding the files provided since they match the existing version. I'll also confirm with Pete later today or tomorrow. Thx, Jen
Comment 9•11 years ago
|
||
sgarrity: what is your timeline for making the logo updates? that will help me choose update vs don't update for some of the firefox pages. thx!
Comment 10•11 years ago
|
||
(In reply to Jennifer Bertsch [:jbertsch] from comment #9) > sgarrity: what is your timeline for making the logo updates? that will > help me choose update vs don't update for some of the firefox pages. thx! Starting immediately, but not pushing anything into production until the Firefox OS release (July 5), I think. Most of the work will happen this week and next.
Comment 11•11 years ago
|
||
Hey Jen, just wondering if you've had a chance to look at the sites and if there's anything you'd like me to review. Thanks.
Flags: needinfo?(jbertsch)
Comment 12•11 years ago
|
||
The mozilla.org (Bedrock) logo updates are now viewable the demo2 server: https://www-demo2.allizom.org/en-US/ The logos on the bedrock site are ready with a few exceptions: 1. The style guide updates are mostly done, but not pushed to demo2 yet (this week). 2. Any ongoing A/B tests haven't been touched - will have to confirm if any should be. 3. Any Facebook tabs hosted on mozilla.org are not updated 4. We still need confirmation on whether or not to update a few files (see Google Doc below) The SVN pages are done on our local development server and accessible at http://mozilla-com-trunk.silverorange.com/en-US/firefox/fx/ (ping me for login info). Everything in SVN is updated except for a few Plugin Check promo banners that we're waiting for confirmation on. The details of our progress are tracked in this Google Doc (https://docs.google.com/a/silverorange.com/spreadsheet/ccc?key=0Au9T8KeO2UcLdEhUdEVIdC15eWRxdmF2UnNKdmRkUlE#gid=0). When it comes time to push these changes into production, the bedrock updates can go together with any other Firefox OS updates (they are already sharing the demo2 server). On the PHP/SVN side, though, I'm keeping the changes local/uncommitted as long as possible, since the SVN trunk/stage servers are public. It would be nice to push the SVN changes at least into trunk as soon as possible. There are also two separate one-page sites that I have updates ready for locally, but will need to be merged/pushed separately from the mozilla.org changes. 1. http://start.mozilla.org/ (managed in https://github.com/mozilla/fx36start) 2. http://itisatrap.org/ (managed in https://github.com/mozilla/itisatrap)
Comment 13•11 years ago
|
||
Thanks Steven. This is looking *really* great. I saw this on the to do list, but should we file a separate bug for https://www.mozilla.org/en-US/products/? Ty needs to update the FxOS panel there anyway.
Comment 14•11 years ago
|
||
We do have this bug open that does touch /product https://bugzilla.mozilla.org/show_bug.cgi?id=871730 if you want to add more changes for /product there
Flags: needinfo?(jbertsch)
Comment 15•11 years ago
|
||
I can't access Bug 871730, but Bug 880777 also covers that page.
Depends on: 880777
Comment 16•11 years ago
|
||
Here's a patch that adds the cache-busting to all images with the Firefox logo on the PHP side of mozilla.org.
Attachment #770782 -
Flags: review?(pmac)
Comment 17•11 years ago
|
||
The logo images in the mozilla.com PHP/SVN repo are updated in trunk in r117651. This will have to merge to stage/prod, and the patch above will need to be updated to ensure cached images are avoided.
Whiteboard: r=117651
Comment 18•11 years ago
|
||
Comment on attachment 770782 [details] [diff] [review] Patch to add cache-busting to Firefox logo images on PHP site Review of attachment 770782 [details] [diff] [review]: ----------------------------------------------------------------- Just a few small fixes, then it's merge ready. r+wc. ::: en-US/firefox/7.0/whatsnew/index.html @@ +45,4 @@ > > > <div id="main-feature"> > + <img src="<?php echo min_inline_image('/img/firefox/3.6/firstrun/logo.png?2013-06')?>" alt="Firefox Logo" id="title-logo" width="128" height="130" /> Not sure what `min_inline_image()` does, but I think the safe bet is to add the `?2013-06` after the `?>`. ::: en-US/firefox/8.0/whatsnew/index.html @@ +43,4 @@ > <div id="doc"> > > <div id="main-feature"> > + <img src="<?php echo min_inline_image('/img/firefox/3.6/firstrun/logo.png?2013-06')?>" alt="Firefox Logo" id="title-logo" width="128" height="130" /> Same as above. Add the cache-bust after the PHP function call. ::: en-US/firefox/ripcurl/index.html @@ +45,4 @@ > > > <div id="main-feature"> > + <img src="<?php echo min_inline_image('/img/firefox/3.6/firstrun/logo.png?2013-06')?>" alt="Firefox Logo" id="title-logo" width="128" height="130" /> Same as above. ::: en-US/firefox/3.6/whatsnew/index.html @@ +12,4 @@ > > > <div id="main-feature"> > + <img src="<?php echo min_inline_image('/img/firefox/3.6/firstrun/logo.png?2013-06')?>" alt="Firefox Logo" id="title-logo" width="128" height="130" /> Same as above. @@ +85,4 @@ > > <div class="sub-feature" id="flash-plus-beta" style="display: none;"> > <a href="/<?=$lang?>/firefox/beta/"> > + <img src="<?php echo min_inline_image('/img/firefox/3.6/firstrun/beta-logo.png?2013-06')?>" alt="Firefox 4 Beta" width="129" height="30" /> Same as above. ::: en-US/firefox/4.0/whatsnew/index.html @@ +43,4 @@ > > > <div id="main-feature"> > + <img src="<?php echo min_inline_image('/img/firefox/3.6/firstrun/logo.png?2013-06')?>" alt="Firefox Logo" id="title-logo" width="128" height="130" /> Same as above. ::: en-US/firefox/5.0/whatsnew/index.html @@ +56,4 @@ > > > <div id="main-feature"> > + <img src="<?php echo min_inline_image('/img/firefox/3.6/firstrun/logo.png?2013-06')?>" alt="Firefox Logo" id="title-logo" width="128" height="130" /> Same as above. ::: en-US/firefox/6.0/whatsnew/index.html @@ +39,4 @@ > > > <div id="main-feature"> > + <img src="<?php echo min_inline_image('/img/firefox/3.6/firstrun/logo.png?2013-06')?>" alt="Firefox Logo" id="title-logo" width="128" height="130" /> Same as above. ::: style/covehead/aurora-releasenotes.css @@ +60,4 @@ > } > > #aurora-relnotes #download_aurora_button a.download-link span.download-content { > + background-image: url(/img/covehead/firefox/aurora/download-logo.png?2013-06?2013-06); Cache-bust doubled.
Attachment #770782 -
Flags: review?(pmac) → review+
Comment 19•11 years ago
|
||
Fixed issues brought up by pmac in his helpful review (thanks) and committed the cache-busting to trunk in r117813. Now, r117651 and r117813 and ready to go into stage/production.
Whiteboard: r=117651 → r=117651, 117813
Comment 20•11 years ago
|
||
Is it okay to mark this bug public now that the logo is public?
Updated•11 years ago
|
Whiteboard: r=117651, 117813 → r=117651,117813
Updated•11 years ago
|
Group: mozilla-corporation-confidential
Comment 21•11 years ago
|
||
Merged to prod in r117818.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•