871746 - mozinfo.update should accept a path to a json file

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

Currently our test harnesses need to do something like this for when using the mozinfo.json generated by writemozinfo.py:
http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#757

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - accept file paths/urls in mozinfo.update

Allowing urls might be overkill and not worth adding in. Say the word and I'll remove it.

Comment 2

[Jeff Hammel]

Comment on attachment 749003 [details] [diff] [review]
Patch 1.0 - accept file paths/urls in mozinfo.update

looks good!  except....

I don't think you want to bump the package version here.  Normally, ABICT, the versionbump.py script is used subsequently to bump the version, ensure intra-mozbase compatability, tag, and release to pypi.  If you want to do all of this manually, I am happy to give you an r+

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 749003 [details] [diff] [review]
Patch 1.0 - accept file paths/urls in mozinfo.update

https://github.com/mozilla/mozbase/commit/8f5ad2855c517eda65809d2fcf35f95dc8f11eb3

I'll need to version bump eventually, but am not in any rush. So I pushed without the version bump. Changing r- to r+

Comment 4

[Jeff Hammel]

coolz, wfm.  my concern is just ensuring the tag and pypi release are concurrent, as well as making sure we don't break internal compatibility