Closed Bug 871765 Opened 13 years ago Closed 13 years ago

Add validation for review submission/edit

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2013-05-16

People

(Reporter: cvan, Assigned: basta)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [fireplace])

Notice the "Submit" button should be disabled for a new review submission: http://cl.ly/image/3C3L2m2B2R2p The ratings `<select>` should be required. This needs to get called: https://github.com/mozilla/fireplace/blob/master/hearth/media/js/forms.js#L10
Keywords: regression
https://github.com/mozilla/fireplace/commit/68da1348c63d878404fdf48da6374c23cfc91eb0
Assignee: nobody → mattbasta
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-05-16
Verified as fixed in https://marketplace-dev.allizom.org/ on FF24 (Win 7) Postfix screencast http://screencast.com/t/BGgDkoSNZK Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.