871777 - Fold load into jump in BaselineHelpers-x64.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Dan Gohman [:sunfish]]

In x64's EmitStubGuardFailure, instead of loading the jump destination into a register, the load can be folded into the jump.

Comment 1

[Dan Gohman [:sunfish]]

Attachment: a proposed fix

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 749019 [details] [diff] [review]
a proposed fix

Review of attachment 749019 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! If you can post an updated patch I will land it for you.

::: js/src/ion/x64/BaselineHelpers-x64.h
@@ +273,2 @@
>      // Return address is already loaded, just jump to the next stubcode.
> +    masm.jmp(Operand(BaselineStubReg, ICStub::offsetOfStubCode()));

We should make the same change to EmitEnterTypeMonitorIC, and fix x86 as well.

Comment 3

[Dan Gohman [:sunfish]]

Attachment: an updated patch, following review feedback

New patch with the same fix applied to EmitEnterTypeMonitorIC and x86.

Comment 4

[Dan Gohman [:sunfish]]

Attachment: a revised patch, per feedback

This time with the correct bug number.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eeeb181131c7

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eeeb181131c7