871781 - Add a prefix option to VariablesView eval macros

Status: RESOLVED INVALID

(DevTools :: General, defect)

Description

[Brandon Benvie [:benvie]]

JSTerm's wrapping of the the VariablesView eval macros has redundent code which can be streamlined rather simply by providing a `prefix` option for those eval macros.

Comment 1

[Brandon Benvie [:benvie]]

Attachment: WIP1

Currently, JSTerm's usage of the VariablesView eval macros works by breaking encapsulation of `Variable` objects (by temporarily modifying their "_symbolicName" property).

This patch adds a trailing `aPrefix` parameter to the three VariablesView eval macro functions. It refactors JSTerm's usage of these functions to use the prefix parameter instead of breaking encapsulation. It also moves them to static properties of JSTerm instead of being properties on the prototype (since they are neither |this| sensitive or changed per instance of JSTerm).

Comment 2

[Brandon Benvie [:benvie]]

This is going to be part of bug 828680, so closing this.