871784 - b2g should specify its debug actors explicitly rather than using addBrowserActors

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

addBrowserActors has some gonk gunk in it.  If b2g/gaia have a different set of actors than the browser, it should just load them manually.

Comment 1

[Dave Camp (:dcamp)]

Comment on attachment 749023 [details] [diff] [review]
v1

Panos, once you've had a look can you pass on to the relevant b2g reviewer please?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 749023 [details] [diff] [review]
v1

Review of attachment 749023 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup. Fabrice, besides moving the b2g-related build hack inside b2g code instead of generic devtools code, this will allow us to radically improve the devtools development workflow by avoiding the build step for preprocessing the debugger server.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 749023 [details] [diff] [review]
v1

Review of attachment 749023 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/shell.js
@@ +1001,5 @@
> +#ifndef MOZ_WIDGET_GONK
> +      DebuggerServer.addActors("chrome://global/content/devtools/dbg-webconsole-actors.js");
> +      DebuggerServer.addActors("chrome://global/content/devtools/dbg-gcli-actors.js");
> +#endif
> +      if ("nsIProfiler" in Ci)

nit: { } even for single line if's

Comment 4

[Jim Blandy :jimb]

Comment on attachment 749023 [details] [diff] [review]
v1

Review of attachment 749023 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!

Comment 5

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/022074c03e7d

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/022074c03e7d