Closed Bug 871786 Opened 6 years ago Closed 6 years ago

Remove KeyboardEvent classinfo

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(2 files, 2 obsolete files)

No description provided.
This is needed because some existing event handlers expect that |instanceof KeyEvent| will return true for keyboard events.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #749027 - Flags: review?(bugs)
Attached patch Remove KeyboardEvent classinfo (obsolete) — Splinter Review
Attachment #749029 - Flags: review?(bugs)
Comment on attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent

I don't know how that Bindings.conf part works.
Attachment #749027 - Flags: review?(bzbarsky)
Attachment #749027 - Flags: review?(bugs)
Attachment #749027 - Flags: review+
Comment on attachment 749029 [details] [diff] [review]
Remove KeyboardEvent classinfo

Could you remove key event from dom_quickstubs.qsconf
Attachment #749029 - Flags: review?(bugs) → review+
Comment on attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent

This looks fine as long as there are no other implementations of KeyEvent.
Attachment #749027 - Flags: review?(bzbarsky) → review+
This is more conformant to the latest spec because KeyEvent will not be inserted into KeyboardEvent's prototype chain.
Attachment #749027 - Attachment is obsolete: true
Attachment #749487 - Flags: review?(bzbarsky)
patch for check-in
Attachment #749029 - Attachment is obsolete: true
Comment on attachment 749487 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent, v2

>+    'nativeType': 'nsDOMKeyboardEvent',

You don't need that is 'concrete':False and nothing concrete inherits from the interface.

r=me with that.
Attachment #749487 - Flags: review?(bzbarsky) → review+
Depends on: 872856
Blocks: 873753
https://hg.mozilla.org/mozilla-central/rev/88a1b42e82a1
https://hg.mozilla.org/mozilla-central/rev/fb4696685200
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.