871786 - Remove KeyboardEvent classinfo

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Separate D2E KeyEvent constants and a method from KeyboardEvent

This is needed because some existing event handlers expect that |instanceof KeyEvent| will return true for keyboard events.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Remove KeyboardEvent classinfo

Comment 3

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=da6f17614cf9

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent

I don't know how that Bindings.conf part works.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 749029 [details] [diff] [review]
Remove KeyboardEvent classinfo

Could you remove key event from dom_quickstubs.qsconf

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent

This looks fine as long as there are no other implementations of KeyEvent.

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: Separate D2E KeyEvent constants and a method from KeyboardEvent, v2

This is more conformant to the latest spec because KeyEvent will not be inserted into KeyboardEvent's prototype chain.

Comment 8

[Masatoshi Kimura [:emk]]

Attachment: Remove KeyboardEvent classinfo. r=smaug

patch for check-in

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 749487 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent, v2

>+    'nativeType': 'nsDOMKeyboardEvent',

You don't need that is 'concrete':False and nothing concrete inherits from the interface.

r=me with that.

Comment 10

[Masatoshi Kimura [:emk]]

Some .wedidl files are added despite of bug 872856. Trying to land.

https://hg.mozilla.org/integration/mozilla-inbound/rev/88a1b42e82a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb4696685200

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/88a1b42e82a1
https://hg.mozilla.org/mozilla-central/rev/fb4696685200