If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove KeyboardEvent classinfo

RESOLVED FIXED in mozilla24

Status

()

Core
DOM: Events
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla24
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent

This is needed because some existing event handlers expect that |instanceof KeyEvent| will return true for keyboard events.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #749027 - Flags: review?(bugs)
(Assignee)

Comment 2

4 years ago
Created attachment 749029 [details] [diff] [review]
Remove KeyboardEvent classinfo
Attachment #749029 - Flags: review?(bugs)
(Assignee)

Comment 3

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=da6f17614cf9

Comment 4

4 years ago
Comment on attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent

I don't know how that Bindings.conf part works.
Attachment #749027 - Flags: review?(bzbarsky)
Attachment #749027 - Flags: review?(bugs)
Attachment #749027 - Flags: review+

Comment 5

4 years ago
Comment on attachment 749029 [details] [diff] [review]
Remove KeyboardEvent classinfo

Could you remove key event from dom_quickstubs.qsconf
Attachment #749029 - Flags: review?(bugs) → review+
Comment on attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent

This looks fine as long as there are no other implementations of KeyEvent.
Attachment #749027 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

4 years ago
Created attachment 749487 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent, v2

This is more conformant to the latest spec because KeyEvent will not be inserted into KeyboardEvent's prototype chain.
Attachment #749027 - Attachment is obsolete: true
Attachment #749487 - Flags: review?(bzbarsky)
(Assignee)

Comment 8

4 years ago
Created attachment 749489 [details] [diff] [review]
Remove KeyboardEvent classinfo. r=smaug

patch for check-in
Attachment #749029 - Attachment is obsolete: true
Comment on attachment 749487 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent, v2

>+    'nativeType': 'nsDOMKeyboardEvent',

You don't need that is 'concrete':False and nothing concrete inherits from the interface.

r=me with that.
Attachment #749487 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

4 years ago
Depends on: 872856
(Assignee)

Updated

4 years ago
Blocks: 873753
(Assignee)

Comment 10

4 years ago
Some .wedidl files are added despite of bug 872856. Trying to land.

https://hg.mozilla.org/integration/mozilla-inbound/rev/88a1b42e82a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb4696685200
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/88a1b42e82a1
https://hg.mozilla.org/mozilla-central/rev/fb4696685200
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.