Closed Bug 871828 Opened 11 years ago Closed 11 years ago

Fix global object sharing for FormHistory

Categories

(Toolkit :: Form Manager, defect)

Product:
Toolkit
Component:
Form Manager
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: gwagner, Assigned: gwagner)

Details

Attachments

(1 file)

patch
1.72 KB, patch
Gavin
: review+
khuey
: review+
Details | Diff | Splinter Review 
I see exceptions during running mochitests for b2g.
[JavaScript Error: "resource://gre/modules/FormHistory.jsm - EXPORTED_SYMBOLS is not an array."
Indeed, it's missing a "this." to handle the case where jsloader.reuseGlobal=true (on b2g). I'll r+ a patch!
Attached patch patch — — Splinter Review 
Assignee: nobody → anygregor

    
  

        Attachment #749058 -
        Flags: review?(khuey)

    
    

    
  
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #1)
> Indeed, it's missing a "this." to handle the case where
> jsloader.reuseGlobal=true (on b2g). I'll r+ a patch!

Ha I didn't see your comment. Feel free to steal the review.

        Attachment #749058 -
        Flags: review?(khuey) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ae2633483d14
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: