Closed Bug 871828 Opened 8 years ago Closed 8 years ago

Fix global object sharing for FormHistory

Categories

(Toolkit :: Form Manager, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: gwagner, Assigned: gwagner)

Details

Attachments

(1 file)

I see exceptions during running mochitests for b2g.
[JavaScript Error: "resource://gre/modules/FormHistory.jsm - EXPORTED_SYMBOLS is not an array."
Indeed, it's missing a "this." to handle the case where jsloader.reuseGlobal=true (on b2g). I'll r+ a patch!
Attached patch patchSplinter Review
Assignee: nobody → anygregor
Attachment #749058 - Flags: review?(khuey)
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #1)
> Indeed, it's missing a "this." to handle the case where
> jsloader.reuseGlobal=true (on b2g). I'll r+ a patch!

Ha I didn't see your comment. Feel free to steal the review.
Attachment #749058 - Flags: review?(khuey) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ae2633483d14
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.