871839 - Currency displayed for Poland is not in złoty

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Set language on phone to Polski
2. Set the region in marketplace-dev to Poland
3. Navigate to the details page for a paid app
4. Notice the purchase button

expected behavior:
App price is converted to złoty and has zł as the symbol

observed behavior:
App price is still 0.99 and the symbol is $

Comment 1

[Christopher Van Wiemeersch [:cvan]]

This won't get fixed until bug 867897 does.

Comment 2

[Matt Basta [:basta]]

False. This is caused by the API not returning a localized price in price_locale.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

For the Polish region I see the currency in złoty just fine:

http://cl.ly/image/2u0G1g281Q1n/Screen%20Shot%202013-05-13%20at%208.26.48%20PM.png

FWIW, language doesn't matter here.

(And Basta's correct - the API does localize this price for us.)

Are there additional STR needed here?

Comment 4

[Andy McKay]

Attachment: price in durango

Comment 5

[Andy McKay]

Did you go to app in english, then change language, then go to app in polish? I don't think the cache is clearing. As far as I can tell the API is returning the currency correctly.

Comment 6

[Matt Basta [:basta]]

(In reply to Andy McKay [:andym] from comment #5)
> Did you go to app in english, then change language, then go to app in
> polish? I don't think the cache is clearing. As far as I can tell the API is
> returning the currency correctly.

We don't let you change your language.

Comment 7

[Christopher Van Wiemeersch [:cvan]]

For region=pl this appears fine: http://f.cl.ly/items/3Y2S2i2E263t2d3v1X30/Screen%20Shot%202013-05-14%20at%208.13.46%20AM.png

And as Andy showed in comment 4, this also works fine in Durango. Any other STR we're missing?

Comment 8

[Matt Basta [:basta]]

Krupa have you tested this in Durango?

Comment 9

[krupa raj[:krupa]]

The app price symbol is set to zl but the price is not being converted. 

$0.99 should be 3.18zl

Comment 10

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj 82[:krupa] from comment #9)
> The app price symbol is set to zl but the price is not being converted. 
> 
> $0.99 should be 3.18zl

Google says 0.99 USD = 3.19 Polish Zloty, but how do we know the price tier? What are we comparing this against?

Comment 11

[Wil Clouser [:clouserw]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #10)
> (In reply to krupa raj 82[:krupa] from comment #9)
> > The app price symbol is set to zl but the price is not being converted. 
> > 
> > $0.99 should be 3.18zl
> 
> Google says 0.99 USD = 3.19 Polish Zloty, but how do we know the price tier?
> What are we comparing this against?

The prices and price_currency tables.  We make the tiers roughly equivalent and then ship, with the idea that we'll revisit occasionally (2x a year maybe) to respond to currency fluctuations.

Comment 12

[Andy McKay]

The value 3.99 is actually showing the USD with the zloty symbol. I'll fix that.

We don't have price tier for zloty see bug 872502.

Comment 13

[Andy McKay]

https://github.com/mozilla/zamboni/commit/c6a5d0d

Comment 14

[Kumar McMillan [:kumar]]

Andy, could you look at this test that is failing? https://ci.mozilla.org/job/marketplace/3940/testReport/junit/workspace.mkt.site.tests.test_helpers/TestMarketButton/test_is_premium_webapp_foreign/ Temporarily disabled: https://github.com/mozilla/zamboni/commit/b08c2d12061faf722b2e7a07b5682f588c435ae1

Shouldn't we support the case of localizing a price for arbitrary locales? E.G. if someone is viewing prices in EUR but their locale is English, wouldn't we show €0.89 instead of €0,89?

Or should we ignore the locale and format price how the regional currency is usually formatted?

Comment 15

[Andy McKay]

Thanks kumar. Please understand everything I'm about to write has been prefixed by an evening drinking vodka with Tarek. All mistakes are his.

I would be fine supporting a fallback from a location to an arbitrary locale, but that code hasn't been written yet. If it had, that would be cool. I think we should explicitly define the fallbacks though. Eg. PLN > EUR, CAD > USD. Even then the fallback from €0.89 to €0,89 is not a change in currency, but in change in showing the data via local. That's subtly and confusingly different.

In this test we explicitly ask for a local and fail if its not there, so I've got a fix for this.

https://github.com/mozilla/zamboni/commit/40fa91

Comment 16

[Kumar McMillan [:kumar]]

Hah! I like it