Closed Bug 871853 Opened 11 years ago Closed 11 years ago

runapp.js: Don't call Services.obs.removeObserver with undefined

Categories

(Firefox OS Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox22 wontfix, firefox23 wontfix, firefox24 fixed)

RESOLVED FIXED
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed

People

(Reporter: gwagner, Assigned: gwagner)

Details

Attachments

(1 file)

seen during running mochitests:
WARNING: NS_ENSURE_TRUE(anObserver && aTopic) failed: file /Volumes/2mac/gaia/2src/xpcom/ds/nsObserverService.cpp, line 123
JavaScript error: chrome://browser/content/runapp.js, line 34: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIObserverService.removeObserver]
Attached patch patchSplinter Review
Assignee: nobody → anygregor
Attachment #749089 - Flags: review?(bugmail)
Comment on attachment 749089 [details] [diff] [review]
patch

This seems by definition safe, but https://wiki.mozilla.org/Modules/FirefoxOS seems to suggest Fabrice or Vivien really need to review this (under Gecko B2G Runtime).
Attachment #749089 - Flags: review?(bugmail) → review?(fabrice)
Attachment #749089 - Flags: review?(fabrice) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f2fcb63f7b91
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: