871944 - B2G MMS: should move MMS codes from dom/mms to dom/mobilemessage

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gene Lian (I already quit Mozilla)]

We should move MMS codes from dom/mms to dom/mobilemessage which collects all the messaging codes including SMS and MMS. This is nothing but a minor issue.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

WIP branch: https://github.com/vicamo/b2g_releases-mozilla-central/tree/bugzilla/871944/move-dom_mms-to-dom_mobilemessage

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Try: https://tbpl.mozilla.org/?tree=Try&rev=2312f2d8f309

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #2)
> Created attachment 751627 [details] [diff] [review]

Some files are `hg mv`ed and are hidden by bugzilla. You might need to download the patch for those parts. :)

Comment 4

[Gene Lian (I already quit Mozilla)]

Comment on attachment 751627 [details] [diff] [review]
patch

Review of attachment 751627 [details] [diff] [review]:
-----------------------------------------------------------------

Looks nice. Please make sure the MMS directory completely disappears after the patch is applied. Btw, this one might be worth uplifting to b2g18 to avoid inconvenient maintenance in the future. I'd suggest ask the approval first and then land it to central and b2g18 at the same time.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Nominate for leo+ because MMS will be shipped on v1.1 and it will be more convenient to have synchronized directory structure with m-c.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/211b56200401

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/211b56200401

Comment 8

[Alex Keybl [:akeybl]]

Please nominate for approval-mozilla-b2g18, since this is not critical.

Comment 9

[Gene Lian (I already quit Mozilla)]

Comment on attachment 751627 [details] [diff] [review]
patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): no.
User impact if declined: no.
Testing completed: yes.
Risk to taking this patch (and alternatives if risky): no.
String or UUID changes made by this patch: no.

This patch is aimed for moving the MMS codes to a better directory. That is, mobilemessage/. I don't think we would have any risk to do so. However, it would make the followers more convenient to land MMS codes to b2g18 if they can be in the same file path.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

You'll be shocked to hear I'm sure that this doesn't apply to b2g18.

Comment 11

[Vicamo Yang [:vicamo][:vyang]]

not at all. We'll handle that, thank you :)

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

Attachment: b2g18

try: https://tbpl.mozilla.org/?tree=Try&rev=b3406d3d04b1

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/c23feed928ac