871951 - Split MakeAPI Server and Client into two repositories

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Jon Buckley]

When I install the MakeAPI from npm I download the following dependencies:

makeapi@0.0.11 node_modules/makeapi
├── habitat@0.4.1
├── node-statsd@0.0.7
├── querystring@0.2.0
├── mongoose-validator@0.2.1 (validator@0.4.28)
├── nunjucks@0.1.8a
├── Faker@0.5.8
├── express@3.0.6 (methods@0.0.1, fresh@0.1.0, range-parser@0.0.4, cookie-signature@0.0.1, buffer-crc32@0.1.1, cookie@0.0.5, debug@0.7.2, commander@0.6.1, mkdirp@0.3.3, send@0.1.0, connect@2.7.2)
├── request@2.20.0 (forever-agent@0.3.0, json-stringify-safe@3.0.0, aws-sign@0.3.0, tunnel-agent@0.3.0, oauth-sign@0.3.0, cookie-jar@0.3.0, mime@1.2.9, qs@0.5.6, http-signature@0.9.11, hawk@0.10.2, form-data@0.0.10)
├── mongoose@3.5.13 (sliced@0.0.3, muri@0.3.1, hooks@0.2.1, ms@0.1.0, mongodb@1.3.3)
└── mongoosastic@0.0.11 (elastical@0.0.9, mongoose@2.6.5)

I strongly suspect we do not need all of these. Probably just request.

Comment 1

[Jon Buckley]

As Matt points out, to fix this properly we need to split the makeapi into a server repo and a client repo.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Does this need to be done for our first integration build?

Comment 3

[Jon Buckley [:jbuck]]

Nope, just a nice-to-have.

Comment 4

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/makeapi-client/pull/1

New Repo: https://github.com/mozilla/makeapi-client

Once we merge this in, I'll tag it and I'll get working on integrating it into other apps, beginning with it's old home (removing it, updating admin usage).

Comment 5

[Chris DeCairos (:cade)]

Merged Attachment 767352 [details] into master: https://github.com/mozilla/makeapi-client/commit/9329eff8f6be0225ed81d6fbe96799012928f3f2

Comment 6

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/227

Update webmaker.org to use the new makeapi repo

Comment 7

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/99

Update MakeAPI repo, removing the client code, adding the new repo as a dep.

Comment 8

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/77

Update popcorn maker with the new makeapi-client repo.

Comment 9

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/161

Update thimble to use the new makeapi-client repo!

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/5d1a1904ba1f3b46cdc743ca3fb61f9030073adc
Bug 871951 - Update package.json with makeapi-client and remove server repository from dependencies. Update references to MakeAPI code.

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/a0a76166ad54101d942ba26f189a34a00e33970b
Bug 871951 - Update package.json with makeapi-client and remove server repository from dependencies. Update references to MakeAPI code.

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/f0cd36aa311f8d03b3b93da7b9fd7fae9476bc56
Bug 871951 - Update package.json with makeapi-client and remove server repository from dependencies. Update references to MakeAPI code.

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/2703d3d8ea2bd51a9e398ba45259f52d4ffcdc5b
Fix Bug 871951 - Remove make-api.js, add new client repo as a dependency and update usage.