xulrunner mirror pushes shouldn't fail if the directory already exists

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 749240 [details] [diff] [review]
add the option to overwrite files in pushes

Whenever we rebuild a beta or release that has already pushed XULRunner to the releases directory, the next push fails. We've never bothered to flush the cdn cache for xulrunner, so we should just overwrite those files automatically IMO.
Attachment #749240 - Flags: review?(nthomas)
Comment on attachment 749240 [details] [diff] [review]
add the option to overwrite files in pushes

Seems fine to me. The risk of some file being removed between buildN and buildN+1, and not getting cleaned up by the later rsync seems very low. Certainly safer than rsync --delete!
Attachment #749240 - Flags: review?(nthomas) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 750434 [details] [diff] [review]
pass the flag

Almost forgot about this part!
Attachment #750434 - Flags: review?(rail)
(Assignee)

Updated

5 years ago
Attachment #749240 - Flags: checked-in+
Attachment #750434 - Flags: review?(rail) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 750434 [details] [diff] [review]
pass the flag

Landed, and I added a comma to fix the syntax...
Attachment #750434 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.