Closed
Bug 871966
Opened 11 years ago
Closed 11 years ago
xulrunner mirror pushes shouldn't fail if the directory already exists
Categories
(Release Engineering :: Release Automation: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(2 files)
3.93 KB,
patch
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
479 bytes,
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Whenever we rebuild a beta or release that has already pushed XULRunner to the releases directory, the next push fails. We've never bothered to flush the cdn cache for xulrunner, so we should just overwrite those files automatically IMO.
Attachment #749240 -
Flags: review?(nthomas)
Comment 1•11 years ago
|
||
Comment on attachment 749240 [details] [diff] [review] add the option to overwrite files in pushes Seems fine to me. The risk of some file being removed between buildN and buildN+1, and not getting cleaned up by the later rsync seems very low. Certainly safer than rsync --delete!
Attachment #749240 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Almost forgot about this part!
Attachment #750434 -
Flags: review?(rail)
Assignee | ||
Updated•11 years ago
|
Attachment #749240 -
Flags: checked-in+
Updated•11 years ago
|
Attachment #750434 -
Flags: review?(rail) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 750434 [details] [diff] [review] pass the flag Landed, and I added a comma to fix the syntax...
Attachment #750434 -
Flags: checked-in+
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•