Closed Bug 871966 Opened 11 years ago Closed 11 years ago

xulrunner mirror pushes shouldn't fail if the directory already exists

Categories

(Release Engineering :: Release Automation: Other, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(2 files)

Whenever we rebuild a beta or release that has already pushed XULRunner to the releases directory, the next push fails. We've never bothered to flush the cdn cache for xulrunner, so we should just overwrite those files automatically IMO.
Attachment #749240 - Flags: review?(nthomas)
Comment on attachment 749240 [details] [diff] [review]
add the option to overwrite files in pushes

Seems fine to me. The risk of some file being removed between buildN and buildN+1, and not getting cleaned up by the later rsync seems very low. Certainly safer than rsync --delete!
Attachment #749240 - Flags: review?(nthomas) → review+
Attached patch pass the flagSplinter Review
Almost forgot about this part!
Attachment #750434 - Flags: review?(rail)
Attachment #749240 - Flags: checked-in+
Attachment #750434 - Flags: review?(rail) → review+
Comment on attachment 750434 [details] [diff] [review]
pass the flag

Landed, and I added a comma to fix the syntax...
Attachment #750434 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: