872031 - clang 3.3 compile errors in accessible/src/mac/AccessibleWrap.mm

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect)

Description

[Nathan Froyd [:froydnj]]

/Users/froydnj/src/mozilla-central-official/accessible/src/mac/AccessibleWrap.mm:37:37: error:
      expected expression
    mNativeObject = [[GetNativeType() alloc] initWithAccessible:this];
                                    ^
/Users/froydnj/src/mozilla-central-official/accessible/src/mac/AccessibleWrap.mm:193:20: error:
      expected expression
  [GetNativeObject() invalidateChildren];
                   ^
2 errors generated.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix clang 3.3 compile errors in AccessibleWrap.mm

I don't pretend to understand exactly what Objective-C++ wants here, but helping
the compiler out by making the method call expression explicit appears to help.

Comment 2

[Hubert Figuiere [:hub]]

Comment on attachment 749292 [details] [diff] [review]
fix clang 3.3 compile errors in AccessibleWrap.mm

Looks good to me. I have no idea what the changed in clang 3.3 but this is what is expected: calling GetNativeType() and GetNativeObject() on this.

(I'm not peer of the module, but I was the maintainer of the Mac code)

Comment 3

[Hubert Figuiere [:hub]]

I really mean: wait that Trevor reviews it too. His call.

Comment 4

[Trevor Saunders (:tbsaunde)]

Comment on attachment 749292 [details] [diff] [review]
fix clang 3.3 compile errors in AccessibleWrap.mm

I don't understnad the error message or what is or isn't wrong, but seems harmless so r=me

Comment 5

[Nathan Froyd [:froydnj]]

I think this was really just seen in clang HEAD builds and they probably fixed it at some point...