clang 3.3 compile errors in accessible/src/mac/AccessibleWrap.mm

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
5 years ago
5 years ago

People

(Reporter: froydnj, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
/Users/froydnj/src/mozilla-central-official/accessible/src/mac/AccessibleWrap.mm:37:37: error:
      expected expression
    mNativeObject = [[GetNativeType() alloc] initWithAccessible:this];
                                    ^
/Users/froydnj/src/mozilla-central-official/accessible/src/mac/AccessibleWrap.mm:193:20: error:
      expected expression
  [GetNativeObject() invalidateChildren];
                   ^
2 errors generated.
(Reporter)

Comment 1

5 years ago
Created attachment 749292 [details] [diff] [review]
fix clang 3.3 compile errors in AccessibleWrap.mm

I don't pretend to understand exactly what Objective-C++ wants here, but helping
the compiler out by making the method call expression explicit appears to help.
Attachment #749292 - Flags: review?(trev.saunders)
Comment on attachment 749292 [details] [diff] [review]
fix clang 3.3 compile errors in AccessibleWrap.mm

Looks good to me. I have no idea what the changed in clang 3.3 but this is what is expected: calling GetNativeType() and GetNativeObject() on this.

(I'm not peer of the module, but I was the maintainer of the Mac code)
Attachment #749292 - Flags: review+
I really mean: wait that Trevor reviews it too. His call.
Comment on attachment 749292 [details] [diff] [review]
fix clang 3.3 compile errors in AccessibleWrap.mm

I don't understnad the error message or what is or isn't wrong, but seems harmless so r=me
Attachment #749292 - Flags: review?(trev.saunders) → review+
(Reporter)

Comment 5

5 years ago
I think this was really just seen in clang HEAD builds and they probably fixed it at some point...
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.