872035 - Do not turn screen on when device is in pocket

Status: RESOLVED DUPLICATE of bug 907112

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

When receiving a notification (like, for example, SMS), the device's screen should not turn on when the proximity sensor reports that there is something close.

Use case here is having the phone in your pocket, for example, while riding your bike to work. Receiving a SMS will turn the screen on, and you might end up unlocking the device in your pocket. This happens nearly everyday in my case, this is not hypothetical.

Comment 1

[Daniel Coloma:dcoloma]

Agree it is bad, but this is a new feature and it is too late to add it to 1.0.1 :(

Comment 2

[:gerard-majax]

The worst is that I've been wondering about this for several months actually, and I don't know why I remember I heard it was a feature and not a bug ... Anyway, could it make it in v1.1 ?

Comment 3

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/9799

Okay, while it's not a priority, I got quickly a fix in the train so I'm sharing it with you. As far as I'm concerned, it's work quite well on master.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 750002 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/9799

I'm not sure how to make this work...

* first, the proximity sensor should not be powered on when the phone is in your pocket

* secondly, and more importantly: we need to turn on the screen in order to vibrate, and we definitely want to vibrate, so we always need to turn on the screen.

Comment 5

[:gerard-majax]

(In reply to Etienne Segonzac (:etienne) from comment #4)
> Comment on attachment 750002 [details]
> Link to Github https://github.com/mozilla-b2g/gaia/pull/9799
> 
> I'm not sure how to make this work...
> 
> * first, the proximity sensor should not be powered on when the phone is in
> your pocket

Do we have any way to probe the sensor value from Gaia instead of listening to the userproximity event ?

Maybe we could only listen in the addNotifications method, thus listening only at the wake up moment, if I get the code path right. But maybe it will be subject to race conditions ...

> 
> * secondly, and more importantly: we need to turn on the screen in order to
> vibrate, and we definitely want to vibrate, so we always need to turn on the
> screen.

Ouch, that's quite a huge stopper :/.

Anyway, thanks for the input !

Comment 6

[:gerard-majax]

Having upgraded my Nexus S to stock Gaia master, I'm still hitting this issue. There is no way we can do further releases without working on this: just a couple of minutes ago, I got a call while in the subway. This resulted in many apps getting started, pictures of my pocket taken :(

Comment 7

[:gerard-majax]

Looks like this has been fixed by bug 907112. So far I'm not able to reproduce this anymore.