If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

menupopups added to the #mainPopupSet are not offset from the top by -3px when the toolbarbutton is located on the #nav-bar

NEW
Unassigned

Status

()

Firefox
Theme
--
enhancement
4 years ago
2 years ago

People

(Reporter: Johan C, Unassigned)

Tracking

({polish})

22 Branch
All
Windows 7
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 749366 [details]
Screenshot

Certain add-ons put their toolbarbutton menupopups in the #mainPopupSet and are therefore not offset by the "margin-top: -3px" rule.

See the screenshot for a better idea of the inconsistency. The 3 middle popups are positioned correctly.


The rule in question:
  http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#781

  @navbarLargeIcons@ .toolbarbutton-1 > menupopup {
    margin-top: -3px;
  }
(Reporter)

Comment 1

4 years ago
Correction: The second, third and last menupopups (see the screenshot) are positioned correctly.

Comment 2

2 years ago
> Certain add-ons put their toolbarbutton menupopups in the #mainPopupSet and are therefore not offset by the "margin-top: -3px" rule.

Can you provide more information on this -3px rule?

I thought most add-ons put their popups in the #mainPopupset
(Reporter)

Comment 3

2 years ago
(In reply to Mike Kaply [:mkaply] from comment #2)
> > Certain add-ons put their toolbarbutton menupopups in the #mainPopupSet and are therefore not offset by the "margin-top: -3px" rule.
> 
> Can you provide more information on this -3px rule?
> 
> I thought most add-ons put their popups in the #mainPopupset

Unfortunately it's been 2 years since I filed this bug, so I'm afraid I can't provide much more information beyond what was initially provided.

That said, I'd guess that the inconsistency in menupopup offsets is due to the fact that some add-ons place their menupopups in the #mainPopupset whereas other add-ons place it as an actual descendant to the toolbarbutton. Here's an example of the latter: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/toolbarbutton#Examples.

As of Firefox 39 the "bug" is still there (you can reproduce it by adding the toolbarbuttons of Stylish and NoScript to the nav-bar).
Severity: normal → enhancement
Keywords: polish
You need to log in before you can comment on or make changes to this bug.