872143 - Make InputWidgetHelper use PromptService asynchronously

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/InputWidgetHelper.js#24

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

I have this little menulist fix in another bug too, but redid it here.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 756737 [details] [diff] [review]
Patch


>   show: function(aElement) {

>+    var p = new Prompt({

var? what are we, animals?

How did I not notice that in all your other patches?

>+      console.log(JSON.stringify(data));

Remove this part

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3106edd4a5a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for robocop-2 failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b11bffd58de9

https://tbpl.mozilla.org/php/getParsedLog.php?id=23725149&tree=Mozilla-Inbound

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b80a6e43af3b

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b80a6e43af3b