872149 - Make payments UI use PromptService asynchronously

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PaymentsUI.js#52

The API is asynchronous so the prompt can be async too.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Sorry to send these all to you, but they're simple.

I really wanted to start attaching a window to these so that we might someday try to do tab-modal prompts. The Payments stuff doesn't seem to give us one though. b2g does something that seems wrong: http://mxr.mozilla.org/mozilla-central/source/b2g/components/PaymentGlue.js#43

I'll file a bug that it would be nice to have a way to get the window.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #1)

> I really wanted to start attaching a window to these so that we might
> someday try to do tab-modal prompts. The Payments stuff doesn't seem to give
> us one though. b2g does something that seems wrong:
> http://mxr.mozilla.org/mozilla-central/source/b2g/components/PaymentGlue.
> js#43

I don't know if that is strictly 'wrong', but it is a bit fragile and makes some assumptions about the selected tab.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 756764 [details] [diff] [review]
Patch

># HG changeset patch
># Parent 191f8e78f44144748a4d4ab1c7af32e6d88bbcf5
>
>diff --git a/mobile/android/components/PaymentsUI.js b/mobile/android/components/PaymentsUI.js
>--- a/mobile/android/components/PaymentsUI.js
>+++ b/mobile/android/components/PaymentsUI.js
>@@ -86,29 +86,26 @@
>         label: requestText,
>         isGroup: false,
>         inGroup: false,
>         disabled: false,
>         id: i

Can't you drop some of these too?

r+, but make those removals too

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80455a25276b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for robocop-2 failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b11bffd58de9

https://tbpl.mozilla.org/php/getParsedLog.php?id=23725149&tree=Mozilla-Inbound

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/994a455c1a99

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/994a455c1a99