872185 - Annotate a couple of rooting analysis false positives

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: Proposed changes

Add annotations to fix the following rooting analysis false positives:

js/src/builtin/Intl.cpp:1280: Function 'int32 js::intl_numberingSystem(JSContext*, uint32, JS::Value*)' has unrooted 'jsname' of type 'JSString*' live across GC call icu_50::UObject.__deleting_dtor 

 - I don't believe ICU objects can call possibly call javascript in their destructors

js/src/ion/AsmJS.cpp:5601: Function 'AsmJS.cpp:uint8 CheckModule(JSContext*, js::frontend::TokenStream*, js::frontend::ParseNode*, struct js::ScopedJSDeletePtr<js::AsmJSModule>*)' has unrooted 'm' of type 'ModuleCompiler' live across GC call 'uint8 ModuleCompiler::init()'

 - ModuleCompiler contains unrooted JSAtoms, however it's not possible for this to be on the stack without an AutoKeepAtoms, so I added this to the annotations and comment in the source.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 749431 [details] [diff] [review]
Proposed changes

Review of attachment 749431 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh. But I can't think of anything better.

Comment 2

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1290fb9b72e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1290fb9b72e