872353 - nsSVGTextFrame2::Reflow does not get called and can be removed

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

nsSVGTextFrame2 isn't a reflow root, so this nsSVGTextFrame2::Reflow is not needed like it is in nsSVGForeignObjectFrame.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Possibly we _should_ make it a reflow root though.

Comment 3

[Jonathan Watt [:jwatt]]

roc, heycam mentioned that he thought you said something about making nsSVGTextFrame2 (or its anonymous block?) a reflow root. Why was that?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't remember what I said.

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 749621 [details] [diff] [review]
patch

Let's get rid of it. We can always put it back if someone comes up with a good reason for it.

Comment 6

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6c656a65a81

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c6c656a65a81