Closed
Bug 872381
Opened 11 years ago
Closed 11 years ago
Do not bake the shape tree depth into tests
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
2.89 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
The attached test asserts that the shape tree enters dictionary mode at a specific depth. Bug 868042 changed the constant to 512 and broke the test introduced with bug 595365. This was not caught because the test was disabled in the browser immediately after landing: it uses the shapeOf shell builtin without testing if it exists.
Attachment #749656 -
Flags: review?(jdemooij)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 749656 [details] [diff] [review] v0 - remove the test. Review of attachment 749656 [details] [diff] [review]: ----------------------------------------------------------------- Yeah this is just an implementation detail.
Attachment #749656 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/680086e7b27f
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/680086e7b27f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•