Closed
Bug 872403
Opened 13 years ago
Closed 12 years ago
Add basic sanity check when restoring legacy state of toolbars
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Unfocused, Assigned: Unfocused)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M5])
Attachments
(1 file)
|
1.06 KB,
patch
|
jaws
:
review+
mconley
:
review+
|
Details | Diff | Splinter Review |
No idea how I got to this, but the currentset for my menubar is "menubar-items,". Note the trailing comma. When we restore legacy state at the moment, we just split by "," - so we get an array of ["menubar-items", ""]. That final empty string breaks things. We should have a sanity check there.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 749699 [details] [diff] [review]
Patch v1
Drive-by:
My inner language-geek is in love with this. :) Still, I think it's worth a comment to say what's going on here. Arrow functions are new enough that (IMO) it warrants a short explanation of what it's doing.
Attachment #749699 -
Flags: review+
|
||
Updated•13 years ago
|
Attachment #749699 -
Flags: review?(jaws) → review+
|
|
||
Updated•13 years ago
|
Blocks: australis-cust
|
|
||
Comment 3•13 years ago
|
||
Doesn't look like there's anything preventing this from landing, so I went for it.
https://hg.mozilla.org/projects/ux/rev/5797ed2e79b6
Whiteboard: [Australis:M5] → [Australis:M5][fixed-in-ux]
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M5][fixed-in-ux] → [Australis:M5]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•