Closed Bug 872439 Opened 7 years ago Closed 7 years ago
Changes in packager breaks Firefox + libxul build
We've got problem with change introduced by bug 780561 when building Firefox with libxul on Fedora. I get: Executing /usr/lib64/xulrunner-devel-21.0/bin/xpcshell -g /usr/lib64/xulrunner-devel-21.0 -a /home/jhorak/fedora/firefox/firefox-21.0/mozilla-release/dist/bin/browser -f ../../toolkit/mozapps/installer/precompile_cache.js -e precompile_startupcache("resource://app/"); failed to get nsJSRuntimeService! Traceback (most recent call last): File "../../toolkit/mozapps/installer/packager.py", line 366, in <module> main() File "../../toolkit/mozapps/installer/packager.py", line 358, in main args.source, gre_path, base) File "../../toolkit/mozapps/installer/packager.py", line 140, in precompile_cache errors.fatal('Error while running startup cache precompilation') File "/home/jhorak/fedora/firefox/firefox-21.0/mozilla-release/python/mozbuild/mozpack/errors.py", line 101, in fatal self._handle(self.FATAL, msg) File "/home/jhorak/fedora/firefox/firefox-21.0/mozilla-release/python/mozbuild/mozpack/errors.py", line 96, in _handle raise ErrorMessage(msg) mozpack.errors.ErrorMessage: Error: Error while running startup cache precompilation make: *** [stage-package] Error 1 It looks fine when -g /usr/lib64/xulrunner-devel-21.0 is replaced by -g /usr/lib64/xulrunner-devel-21.0/bin
Jan, can you check this? A workaround that should work, if you don't want to apply a patch, is to run: make package LIBXUL_DIST=/usr/lib64/xulrunner-devel-21.0/bin.
Attachment #749765 - Flags: review?(gps)
Please check that the patch fixes it for you whether you want to apply it in the packaging or not, though.
Problem has been fixed with attached patch.
Comment on attachment 749765 [details] [diff] [review] Fix GRE path used for startup cache precompilation with --with-libxul-sdk [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 780561 User impact if declined: make package failure on builds with --with-libxul-sdk (xulrunner applications) Testing completed (on m-c, etc.): tested locally by Jan Risk to taking this patch (and alternatives if risky): NPOTB for Firefox String or IDL/UUID changes made by this patch: None (requesting for release in case there's a chemspill planned)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Does this affect FF21? We could consider it for a ride-along if there was a 21.0.1 at some point in the coming weeks if so. Otherwise it will be fixed in FF22.
(In reply to firstname.lastname@example.org [:lsblakk] from comment #8) > Does this affect FF21? We could consider it for a ride-along if there was a > 21.0.1 at some point in the coming weeks if so. Otherwise it will be fixed > in FF22. Yes it does. We've fixed that in our package by using attached patch.
There is no planned chemspill at this point for Fx21.0, so I am removing the approval for release on this patch . I will revisit the issue if at all there is a chemspill/dot release in future weeks but seems unlikely at this point.
Attachment #749765 - Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in before you can comment on or make changes to this bug.