872464 - [Building Blocks] Add labels to list buttons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Sergi]

We should add the possibility of adding a label on top of a list button. This is specially important for buttons opening a value selector.

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: Patch

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 749808 [details]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: not matching UX requirements.
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low. This patch modifies visual styles when creating a new contact. e.g. Tap "Mobile" on phone are to get the grouped buttons screen. That screen has not been implemented as designed from the very beginning, so any way, although is changing its look, has to be redesigned like that: https://bug836622.bugzilla.mozilla.org/attachment.cgi?id=724970 
String or UUID changes made by this patch:

Comment 3

[Alex Keybl [:akeybl]]

Comment on attachment 749808 [details]
Patch

An enhancement like this is out of scope for v1.1 at this point.

Comment 4

[Sergi]

There's a bug depending on this: https://bugzilla.mozilla.org/show_bug.cgi?id=867038

I've added a blocker.

Comment 5

[Dylan Oliver [:doliver]]

Re-nominating to evaluate for v1.1 -- this is blocking a leo+ feature (bug 867038). The alternative would be to create a local version of this BB used by the Clock.

Comment 6

[Dylan Oliver [:doliver]]

Mike -- do you know where else this BB is being used? Or can you do a quick search to see if other apps are affected?

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Dylan,

This style sheet is used by most apps in gaia: browser, calendar, contacts, ftu, costcontrol, email, homescreen, settings, wallpaper.

Should I go ahead and just create a local version of buttons.css for clock? If so, do we need to file a new bugzilla report for the app?

Comment 8

[Dylan Oliver [:doliver]]

Clearing nomination. Discussed with Mike -- to limit risk, he'll import these changes into Clock and use a local version for 1.1. We'll revert to this shared version in 1.2 when it has more time to bake.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Note: bug 880431 contains the workaround, and bug 880445 reverts the workaround. I'm working with gaye right now to get this uplifted today.