[CONTACTS][FTU] Use the new OAuth redirection mechanism to log in services like Facebook, Gmail or Outlook

RESOLVED FIXED

Status

Firefox OS
Gaia::Contacts
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: arcturus, Assigned: arcturus)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.1 fixed)

Details

(Whiteboard: [status: fixed] [required_last_cert_round] )

Attachments

(3 attachments, 1 obsolete attachment)

Since bug 852848 landed, now we have a new way of capturing Oauth redirections within privileged apps.

We should use this new way of working with oauth in the apps that are already using OAuth authentication against services like Facebook, Gmail or Outlook.

This will affect both Contacts and FTU apps
blocking-b2g: --- → tef?
Depends on: 852848
We need to fix this in order to complete the work started on 852848 so we can avoid going through http
Assignee: nobody → francisco.jordano
blocking-b2g: tef? → tef+
Created attachment 749916 [details]
Pointer to PR 9794
Attachment #749916 - Flags: review?(jmcf)
Attachment #749916 - Flags: feedback?(fabrice)
Created attachment 749945 [details]
v1.0.1 rebase diff

just in case, since the uplift won't be easy.
Attachment #749945 - Flags: review?(jmcf)
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected
Attachment #749916 - Flags: feedback?(fabrice) → feedback+

Updated

5 years ago
Whiteboard: [status: needs review]
Created attachment 750429 [details]
v1.0.1 rebase diff

Updating patch for 1.0.1 branch with latest comments
Attachment #749945 - Attachment is obsolete: true
Attachment #749945 - Flags: review?(jmcf)

Updated

5 years ago
Whiteboard: [status: needs review] → [status: needs review] [required_last_cert_round]

Updated

5 years ago
Attachment #749916 - Flags: review?(jmcf) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Hi John,

the patch should apply to v1-train (in theory)

But for v1.0.1 it won't, just provided a diff for uplifting this patch to v1.0.1 at https://bugzilla.mozilla.org/attachment.cgi?id=750429

Thanks!
F.
Flags: needinfo?(jhford)
v1-train: 8d721227107f8f6945f795aab9764a56d2d1c0c7
v1.0.1: 104b7a7ff81b10f422e1b11d052520251c69bd00

You were right, it applied to v1-train but not v1.0.1

Thanks for providing the v1.0.1 patch!
Flags: needinfo?(jhford)
status-b2g18: affected → fixed
status-b2g18-v1.0.1: affected → fixed

Updated

5 years ago
Whiteboard: [status: needs review] [required_last_cert_round] → [status: fixed] [required_last_cert_round]
Created attachment 752053 [details]
Fix uplift to v1.0.1

During the uplift to 1.0.1 the patch was adding a new folder with several files, those files were missing in the uplift.

This PR adds the missing files and a renaming.

Thanks!
Attachment #752053 - Flags: review?(jmcf)

Updated

5 years ago
Attachment #752053 - Flags: review?(jmcf) → review+

Comment 11

5 years ago
Can you please provide steps to verify this fix as we will blackbox test from the UI?

Comment 12

5 years ago
Unable to verify. Lack of resources. Need Bluetooth PTS tool to verify.
Marking as QARegressExclude.
Whiteboard: [status: fixed] [required_last_cert_round] → [status: fixed] [required_last_cert_round] QARegressExclude

Comment 13

5 years ago
Comment 12 was left by mistake.
Please disregard.
Whiteboard: [status: fixed] [required_last_cert_round] QARegressExclude → [status: fixed] [required_last_cert_round]

Comment 14

5 years ago
Can you please provide steps to verify this fix as we will blackbox test from the UI?
You need to log in before you can comment on or make changes to this bug.