Closed Bug 872512 Opened 11 years ago Closed 11 years ago

[CONTACTS][FTU] Use the new OAuth redirection mechanism to log in services like Facebook, Gmail or Outlook

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.1 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: arcturus, Assigned: arcturus)

References

Details

(Whiteboard: [status: fixed] [required_last_cert_round] )

Attachments

(3 files, 1 obsolete file)

Pointer to PR 9794
356 bytes, text/html
jmcf
: review+
fabrice
: feedback+
Details
v1.0.1 rebase diff
5.70 KB, text/x-patch
Details
Fix uplift to v1.0.1
356 bytes, text/html
jmcf
: review+
Details 
Since bug 852848 landed, now we have a new way of capturing Oauth redirections within privileged apps.

We should use this new way of working with oauth in the apps that are already using OAuth authentication against services like Facebook, Gmail or Outlook.

This will affect both Contacts and FTU apps
blocking-b2g: --- → tef?
Depends on: 852848
We need to fix this in order to complete the work started on 852848 so we can avoid going through http
Assignee: nobody → francisco.jordano
blocking-b2g: tef? → tef+
Attached file Pointer to PR 9794 — 

        Attachment #749916 -
        Flags: review?(jmcf)

        Attachment #749916 -
        Flags: feedback?(fabrice)

    
    

    
  

      
      
      
      

        Attached file
          
        v1.0.1 rebase diff (obsolete)
        — 
      

    


  
just in case, since the uplift won't be easy.

        Attachment #749945 -
        Flags: review?(jmcf)

        Attachment #749916 -
        Flags: feedback?(fabrice) → feedback+
Whiteboard: [status: needs review]

    
    

    
  

      
      
      
      

        Attached file
          
        v1.0.1 rebase diff
        — 
      

    


  
Updating patch for 1.0.1 branch with latest comments

        Attachment #749945 -
        Attachment is obsolete: true

        Attachment #749945 -
        Flags: review?(jmcf)
Whiteboard: [status: needs review] → [status: needs review] [required_last_cert_round]

    
  

        Attachment #749916 -
        Flags: review?(jmcf) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Hi John,

the patch should apply to v1-train (in theory)

But for v1.0.1 it won't, just provided a diff for uplifting this patch to v1.0.1 at https://bugzilla.mozilla.org/attachment.cgi?id=750429

Thanks!
F.
Flags: needinfo?(jhford)

    
    

    
  
v1-train: 8d721227107f8f6945f795aab9764a56d2d1c0c7
v1.0.1: 104b7a7ff81b10f422e1b11d052520251c69bd00

You were right, it applied to v1-train but not v1.0.1

Thanks for providing the v1.0.1 patch!
Flags: needinfo?(jhford)
Whiteboard: [status: needs review] [required_last_cert_round] → [status: fixed] [required_last_cert_round]

    
    

    
  

      
      
      
      

        Attached file
          
        Fix uplift to v1.0.1
        — 
      

    


  
During the uplift to 1.0.1 the patch was adding a new folder with several files, those files were missing in the uplift.

This PR adds the missing files and a renaming.

Thanks!

        Attachment #752053 -
        Flags: review?(jmcf)

    
  

        Attachment #752053 -
        Flags: review?(jmcf) → review+

    
    

    
  
Can you please provide steps to verify this fix as we will blackbox test from the UI?

    
    

    
  
Unable to verify. Lack of resources. Need Bluetooth PTS tool to verify.
Marking as QARegressExclude.
Whiteboard: [status: fixed] [required_last_cert_round] → [status: fixed] [required_last_cert_round] QARegressExclude

    
    

    
  
Comment 12 was left by mistake.
Please disregard.
Whiteboard: [status: fixed] [required_last_cert_round] QARegressExclude → [status: fixed] [required_last_cert_round]

    
    

    
  
Can you please provide steps to verify this fix as we will blackbox test from the UI?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: