872535 - The Customize command stops working the second time on UX

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[(no longer active)]

STR:

1. Customize once, and then close the customize tab.
2. Try customizing again.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I think I need more information here. Is there anything in the Error Console when it breaks? And how is it broken?

Comment 2

[(no longer active)]

(In reply to comment #1)
> I think I need more information here. Is there anything in the Error Console
> when it breaks?

No.

> And how is it broken?

It's disabled.  I thought you said this is known?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

> 
> > And how is it broken?
> 
> It's disabled.  I thought you said this is known?

Once I saw that it's broken via the perma-disabled button, it told me where the problem is. I've seen this problem before, but it's not one that we already have a bug filed for, which is why I'm keeping this open.

Something is going wrong with the customization end event listener in browser-customization.js. It's not completing, and frustratingly, it's not putting anything in the Error Console.

Comment 5

[u428464]

FWIW I encounter this issue after putting the bookmarks button out of the toolbar. When I put it back it works again.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

As pointed out in bug 872738, I'm pretty sure this is related to the bookmark star. In fact, it's probably bug 871322 rearing its head, which it seems hasn't merged into UX yet. I'll try to do a merge right now.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

I believe this was fixed by bug 871322 merging into UX. Please re-open if this is still an issue.