872561 - [B2G][1.0.1] Cannot send_keys to input element/element is is_displayed=False

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Zac C (:zac)]

Attachment: screenshot

On v1.0.1 this input element wider than the width of the Persona frame is inaccessible by Marionette.

The element is "is_displayed() = True" but when attempting to send_keys Marionette is raising an ElementNotVisibleException

This is slightly complicated by a rendering difference between v1.0.1 and v1-train... On v1-train on the same HTML the input element is within the width of the frame and Marionette can interact with it.

------------
TEST-START test_marketplace_purchase_app_wifi.py
test_marketplace_purchase_app_wifi (test_marketplace_purchase_app_wifi.TestMarketplacePurchaseAppWifi) ... 
size: {u'width': 276.45001220703125, u'height': 44}
location: {u'y': 108.75, u'x': 20}
displayed: True

ERROR

======================================================================
ERROR: test_marketplace_purchase_app_wifi (test_marketplace_purchase_app_wifi.TestMarketplacePurchaseAppWifi)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/zacdev/Mozilla/gaia-ui-tests/gaiatest/tests/marketplace/test_marketplace_purchase_app_wifi.py", line 40, in test_marketplace_purchase_app_wifi
    persona.login(self.user.email, self.user.password)
  File "/home/zacdev/Mozilla/gaia-ui-tests/gaiatest/apps/persona/app.py", line 40, in login
    login.type_create_password(password)
  File "/home/zacdev/Mozilla/gaia-ui-tests/gaiatest/apps/persona/regions/login.py", line 60, in type_create_password
    password_field.send_keys(value)
  File "/home/zacdev/.virtualenvs/gaia-ui-27/local/lib/python2.7/site-packages/marionette_client-0.5.27-py2.7.egg/marionette/marionette.py", line 71, in send_keys
    return self.marionette._send_message('sendKeysToElement', 'ok', element=self.id, value=typing)
  File "/home/zacdev/.virtualenvs/gaia-ui-27/local/lib/python2.7/site-packages/marionette_client-0.5.27-py2.7.egg/marionette/marionette.py", line 344, in _send_message
    self._handle_error(response)
  File "/home/zacdev/.virtualenvs/gaia-ui-27/local/lib/python2.7/site-packages/marionette_client-0.5.27-py2.7.egg/marionette/marionette.py", line 371, in _handle_error
    raise ElementNotVisibleException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_marketplace_purchase_app_wifi.py TestMarketplacePurchaseAppWifi.test_marketplace_purchase_app_wifi | ElementNotVisibleException: Element is not visible
----------------------------------------------------------------------
Ran 1 test in 88.658s

Comment 1

[Zac C (:zac)]

NB I have not provided a test case because it is likely to be lost upon the resolution of this Persona issue:
https://github.com/mozilla/browserid/issues/3409

AutomatedTester is debugging this in the meantime.

Comment 2

[David Burns :automatedtester]

I have loosened the elementInView to check if any of the points are in view and if the corners are are out of view but the center is in view lets say its in view.

Mobile try: https://tbpl.mozilla.org/?tree=Try&rev=3d3aee7c88e3
Desktop try: https://tbpl.mozilla.org/?tree=Try&rev=09097e1464fc

Comment 3

[David Burns :automatedtester]

Attachment: loosen elementInView and check centre if in view

Comment 4

[David Burns :automatedtester]

Comment on attachment 750997 [details] [diff] [review]
loosen elementInView and check centre if in view

There was a mobile failure so will check before setting review again

Comment 5

[David Burns :automatedtester]

I cant reproduce the mobile try failure so trying again 

https://tbpl.mozilla.org/?tree=Try&rev=3174c9edf307

Comment 6

[David Burns :automatedtester]

wow.. my first go was waaaaay off

this looks better so try links below

mobile 
https://tbpl.mozilla.org/?tree=Try&rev=1f4011528224

desktop
https://tbpl.mozilla.org/?tree=Try&rev=77279ac24030

Comment 7

[David Burns :automatedtester]

Attachment: loosen elementInView and check centre if in view

Comment 8

[David Burns :automatedtester]

mdas spotted a minor flaw with calculations so am redoing

https://tbpl.mozilla.org/?tree=Try&rev=07f16e4881fd
https://tbpl.mozilla.org/?tree=Try&rev=016d0a0daa3f

Comment 9

[David Burns :automatedtester]

Attachment: loosen elementInView and check centre if in view

Comment 10

[Malini Das [:mdas] - Away, not checking bugmail]

In addition to offline comments about finding the center, I think this patch may only be checking the top left and bottom right corners, but not the top right/bottom left?

Comment 11

[David Burns :automatedtester]

adding top right/bottom left since I hadnt thought it necessary so new try

https://tbpl.mozilla.org/?tree=Try&rev=304df4a153f2
https://tbpl.mozilla.org/?tree=Try&rev=eac7c9a83d49

Comment 12

[David Burns :automatedtester]

Attachment: loosen elementInView and check centre if in view

Comment 13

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 753932 [details] [diff] [review]
loosen elementInView and check centre if in view

Review of attachment 753932 [details] [diff] [review]:
-----------------------------------------------------------------

This patch doesn't contain the new changes :(

Comment 14

[David Burns :automatedtester]

remote:   https://tbpl.mozilla.org/?tree=Try&rev=eac7c9a83d49
☁  mozilla-inbound  hg qref -m "Bug 872561 - Loosening the elementInView and also checking the centre of the element is in view; r=mdas"
☁  mozilla-inbound  google django-cronjob
☁  mozilla-inbound

Spot the missing step....

sorry!

Comment 15

[David Burns :automatedtester]

Attachment: loosen elementInView and check centre if in view

Comment 16

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 754155 [details] [diff] [review]
loosen elementInView and check centre if in view

Review of attachment 754155 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-listener.js
@@ +801,5 @@
> +            rect.left >= curWindow.pageXOffset &&
> +            rect.left <= (curWindow.pageXOffset + curWindow.innerWidth)) ||
> +           /* Center of the element is in view if element larger than viewport */
> +           (((rect.top + (rect.height/2)) <= curWindow.pageYOffset) &&
> +            ((rect/top + (rect.height/2)) <= (curWindow.pageYOffset + curWindow.innerHeight)) &&

should be:

 ((rect.top + (rect.height/2)) >= (curWindow.pageYOffset + curWindow.innerHeight)) &&

@@ +803,5 @@
> +           /* Center of the element is in view if element larger than viewport */
> +           (((rect.top + (rect.height/2)) <= curWindow.pageYOffset) &&
> +            ((rect/top + (rect.height/2)) <= (curWindow.pageYOffset + curWindow.innerHeight)) &&
> +            (rect.left+ (rect.width/2)) <= curWindow.pageXOffset &&
> +           ((rect.left + (rect.width/2)) <= (curWindow.pageXOffset + curWindow.innerWidth)))

and

((rect.left + (rect.width/2)) >= (curWindow.pageXOffset + curWindow.innerWidth)))

Comment 17

[David Burns :automatedtester]

Attachment: loosen elementInView and check centre if in view correcting calculation and cleaning nits I spotted

Comment 18

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/44bda40fd2b7

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/44bda40fd2b7

Comment 20

[David Burns :automatedtester]

We need to land this in v1.0.1 and mozilla-b2g18 for test harness updates, with
a=test-only

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/e71666dea332
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/f0f4522ba846