Closed Bug 872599 Opened 9 years ago Closed 7 years ago

Use AutoSafeJSContext in SaveProfileTask::Run

Categories

(Core :: Gecko Profiler, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

No description provided.
Bobby is rewriting a bunch of this stuff, so I'll wait a bit.
Depends on: 868130
Bobby, is this settled down enough that it would make sense to write this patch now?
Flags: needinfo?(bobbyholley+bmo)
OS: Windows 2000 → All
Yes, should be. Does this stuff run with internal linkage? If not, you won't be able to use AutoSafeJSContext. But you can get the safe JSContext from xpc and push it with AutoCxPusher, which effectively does the same thing.
Flags: needinfo?(bobbyholley+bmo)
SaveProfileTask::Run() doesn't do anything scary any more with contexts.  ProfileGatherer::Finish() seems to use AutoJSAPI now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.