Closed Bug 872737 Opened 7 years ago Closed 7 years ago

Support distribution bookmarks from a /system location

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

patch
3.39 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
Follow-up to bug 843821. See bug 836450 for more details on distribution bookmarks.
Assignee: nobody → margaret.leibovic
Attached patch patch — — Splinter Review 
This is starting to get a bit hairy, but I tried to add comments to explain everything that's going on.

I tested with different combinations of APK/system distributions (APK distribution still overrides the /system distribution), and I commented out the line where we set the STATE_SET pref to test the STATE_UNKNOWN code path in here (otherwise I wasn't hitting it).
Attachment #750118 - Flags: review?(mark.finkle)
Comment on attachment 750118 [details] [diff] [review]
patch

It is a little hairy, but still understandable
Attachment #750118 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bea9e0a6d01

This is isolated enough that we could safely uplift it if we need it sooner than Fx24.
https://hg.mozilla.org/mozilla-central/rev/0bea9e0a6d01
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.