872761 - Refactor site identity block logic into a component that can be reused across products

Status: RESOLVED WONTFIX

(Firefox :: Security, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Two goals:

1. Make it easy to maintain this logic in a way that minimizes the need to write product-specific patches for FxDesktop, FxAndroid, and B2G.

2. Make it easy to test the logic. For example, it should be easy to test that the correct indicator is shown when a cert error override is in effect.

On IRC, we decided this logic should live in toolkit/modules/SiteIdentity.jsm and that the string bundles should be in toolkit/locales/en-US/chrome/global.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Bug 872910 gives some evidence of the usefulness of having the page info dialog box and the certificate manager share the same UI logic too.

Comment 2

[Daniel Veditz [:dveditz]]

Tanvi: we done a bunch of re-working of this info box, is this bug still useful?

Comment 3

[Tanvi Vyas[:tanvi]]

I don't see a need for this bug.  I know Android UI is slightly different, but somewhat intentionally because they have different UI constraints that Desktop doesn't have (less space for text and complicated icons).

Closing won't fix, but also cc'ing Panos and Chenxia who are free to reopen if they think we still need this bug.