872786 - Gather more information when minidumps fail

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Seems like we could at least call GetLastError and report that. Maybe there are other things we can do too.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm going to try to test it here: https://tbpl.mozilla.org/?tree=Try&rev=da5eabb5aafe
retriggering tests of bug 870002

Comment 3

[(not currently active) Ted Mielczarek]

https://tbpl.mozilla.org/php/getParsedLog.php?id=23021195&full=1&branch=try#error0

FYI

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, it worked :-). Can we take this patch? :-)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This patch would also help collect information for bug 872996.

Comment 6

[Robert Kaiser]

In what way do we get info from this in the crash report? That is, in what way (annotation?) will this appear in the report sent to crash-stats (Socorro)?

Comment 7

[(not currently active) Ted Mielczarek]

This is not sent at all with the crash report, it's simply information printed to stderr, so only useful for crashes encountered in automation.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We could probably get the information into a crash report, but we could take this first.

Comment 9

[(not currently active) Ted Mielczarek]

Comment on attachment 750257 [details] [diff] [review]
fix

Review of attachment 750257 [details] [diff] [review]:
-----------------------------------------------------------------

So, as-written I don't think I'd take this patch. It only provides value in the automated testing case, since it's just spewing this to stderr. Additionally, I'm not sure upstream Breakpad would really want this since it doesn't add value in reporting.

If we were going to take this, I think we could do it purely in Mozilla code. nsExceptionHandler.cpp already has a filter callback that gets the EXCEPTION_POINTERS object before a minidump is written:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/nsExceptionHandler.cpp#748

and then the Minidump callback gets a succeeded value indicating whether the dump was written successfully:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/nsExceptionHandler.cpp#405

So we could store the exception info in the former and print it in the latter if !succeeded.