87281 - Table font non-inheritance quirk present in XML

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P1)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
   http://hixie.ch/tests/adhoc/css/box/table/007.xml

ACTUAL RESULTS
   A <table> tag doesn't behave the same as a <p> tag with 'display: table' as
   far as inheriting fonts goes, and, more importantly, it shows the quirky
   behaviour that is so hated by authors world wide.

EXPECTED RESULTS
   Tables should not do anything special w.r.t. font inheritance!

This is, I believe, a regression.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In a conversation I just had with hyatt we thought this might be similar to bug
83495 -- we might need to do the same fix in nsXMLDocument.  (Or maybe even
refactor and end up with code in nsDocument...)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The first set of changes in the patch are |#if 0|-ed out, but I brought them up
to date with the place to which they were copied, which was the second set.

nsHTMLDocument and nsXMLDocument inherit from nsMarkupDocument, but
nsHTMLDocument overrides CreateShell while nsXMLDocument does not.

Comment 4

[Marc Attinasi]

So the default behavior of nsMarkupDocument is to set the mode to standard, and
only HTMLDocument will change this now, right? I like the change, but I think it
should be documented in comments in nsMarkupDocument and nsHTMLDocument so it is
not just magic. [s]r=attinasi

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: while I'm here, avoid direct test against NS_OK

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: same thing, but add comment to nsIPresContext.h

Comment 7

[David Hyatt]

r/sr=hyatt

dbaron, you should take this.  attinasi can give you the second review, and we
can get this in quickly.

Comment 8

[Marc Attinasi]

[s]r=attinasi - I was actually thinking that the nsMarkupDocument needed the
comment to indicate that it was setting the CompatMode to Standard (so
subclasses would know if they need to override it or not), but I like the
comment on the PresContext too.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

OK, taking.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2001-06-26 19:25 PDT.

Comment 11

[Amarendra Hanumanula]

 Marking the bug verified