If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Table font non-inheritance quirk present in XML

VERIFIED FIXED in mozilla0.9.3

Status

()

Core
Layout: Tables
P1
major
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: Hixie (not reading bugmail), Assigned: dbaron)

Tracking

(4 keywords)

Trunk
mozilla0.9.3
x86
Windows 2000
css1, css2, regression, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Hixie-P1], URL)

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
STEPS TO REPRODUCE
   http://hixie.ch/tests/adhoc/css/box/table/007.xml

ACTUAL RESULTS
   A <table> tag doesn't behave the same as a <p> tag with 'display: table' as
   far as inheriting fonts goes, and, more importantly, it shows the quirky
   behaviour that is so hated by authors world wide.

EXPECTED RESULTS
   Tables should not do anything special w.r.t. font inheritance!

This is, I believe, a regression.
(Reporter)

Updated

17 years ago
Severity: normal → major
Keywords: css1, css2, mozilla0.9.2, mozilla0.9.3, nsbeta1, regression, testcase
Whiteboard: [Hixie-P1]

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.3
(Assignee)

Comment 1

17 years ago
In a conversation I just had with hyatt we thought this might be similar to bug
83495 -- we might need to do the same fix in nsXMLDocument.  (Or maybe even
refactor and end up with code in nsDocument...)
(Assignee)

Comment 2

17 years ago
Created attachment 40176 [details] [diff] [review]
patch
(Assignee)

Comment 3

17 years ago
The first set of changes in the patch are |#if 0|-ed out, but I brought them up
to date with the place to which they were copied, which was the second set.

nsHTMLDocument and nsXMLDocument inherit from nsMarkupDocument, but
nsHTMLDocument overrides CreateShell while nsXMLDocument does not.

Comment 4

17 years ago
So the default behavior of nsMarkupDocument is to set the mode to standard, and
only HTMLDocument will change this now, right? I like the change, but I think it
should be documented in comments in nsMarkupDocument and nsHTMLDocument so it is
not just magic. [s]r=attinasi
(Assignee)

Comment 5

17 years ago
Created attachment 40180 [details] [diff] [review]
while I'm here, avoid direct test against NS_OK
(Assignee)

Comment 6

17 years ago
Created attachment 40193 [details] [diff] [review]
same thing, but add comment to nsIPresContext.h

Comment 7

17 years ago
r/sr=hyatt

dbaron, you should take this.  attinasi can give you the second review, and we
can get this in quickly.

Comment 8

17 years ago
[s]r=attinasi - I was actually thinking that the nsMarkupDocument needed the
comment to indicate that it was setting the CompatMode to Standard (so
subclasses would know if they need to override it or not), but I like the
comment on the PresContext too.
(Assignee)

Comment 9

17 years ago
OK, taking.
Assignee: hyatt → dbaron
Status: ASSIGNED → NEW
Priority: -- → P1
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 10

17 years ago
Fix checked in 2001-06-26 19:25 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
 Marking the bug verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.