Closed
Bug 872813
Opened 13 years ago
Closed 13 years ago
remove decomposing opcodes
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: Benjamin, Assigned: Benjamin)
References
Details
Attachments
(1 file, 3 obsolete files)
Now that JägerMonkey is gone, the last "valid" usage of decomposing opcodes is gone. They're merely contributing code bloat now, so let's nuke 'em.
|
Assignee | |
Comment 1•13 years ago
|
||
The main changes are in BytecodeEmitter.cpp. The logic for incrementing and decrementing was (is) quite convoluted. It could perhaps stand to be refactored more. (followup?)
Assignee: general → benjamin
Attachment #750239 -
Flags: review?(luke)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Remove some debugging code.
Attachment #750239 -
Attachment is obsolete: true
Attachment #750239 -
Flags: review?(luke)
Attachment #750241 -
Flags: review?(luke)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 750241 [details] [diff] [review]
zap
Review of attachment 750241 [details] [diff] [review]:
-----------------------------------------------------------------
Nice! Yes, the emitter could use some further cleanup. Btw, I recommend fuzzing before landing.
::: js/src/frontend/BytecodeEmitter.cpp
@@ +923,5 @@
> return EmitAliasedVarOp(cx, op, pn, bce);
> }
>
> +static JSOp
> +GetIncDecInfo(ParseNodeKind kind, bool &post)
The usual SM style is to take outparams by *, not & (so that it is clear at the callsite).
@@ +1776,1 @@
> pn2 = pn->maybeExpr();
Can haz ParseNode *pn2 = pn->maybeExpr()?
Attachment #750241 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Fuzz please.
Attachment #750241 -
Attachment is obsolete: true
Attachment #750838 -
Flags: review+
Attachment #750838 -
Flags: feedback?(gary)
|
|
Assignee | |
Comment 5•13 years ago
|
||
Erk, here's an actually updated patch.
Attachment #750838 -
Attachment is obsolete: true
Attachment #750838 -
Flags: feedback?(gary)
Attachment #750839 -
Flags: review+
Attachment #750839 -
Flags: feedback?(gary)
|
|
||
Updated•13 years ago
|
Attachment #750839 -
Flags: feedback?(choller)
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 750839 [details] [diff] [review]
updated for fuzzing
Didn't find anything after a round of overnight fuzzing.
Attachment #750839 -
Flags: feedback?(gary) → feedback+
|
||
Comment 7•13 years ago
|
||
Comment on attachment 750839 [details] [diff] [review]
updated for fuzzing
Nothing found here either within 24 hours of fuzzing :)
Attachment #750839 -
Flags: feedback?(choller) → feedback+
|
|
Assignee | |
Comment 8•13 years ago
|
||
|
||
Comment 9•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•