Closed Bug 872813 Opened 8 years ago Closed 8 years ago

remove decomposing opcodes

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: Benjamin, Assigned: Benjamin)

References

Details

Attachments

(1 file, 3 obsolete files)

Now that JägerMonkey is gone, the last "valid" usage of decomposing opcodes is gone. They're merely contributing code bloat now, so let's nuke 'em.
Attached patch zap (obsolete) — Splinter Review
The main changes are in BytecodeEmitter.cpp. The logic for incrementing and decrementing was (is) quite convoluted. It could perhaps stand to be refactored more. (followup?)
Assignee: general → benjamin
Attachment #750239 - Flags: review?(luke)
Attached patch zap (obsolete) — Splinter Review
Remove some debugging code.
Attachment #750239 - Attachment is obsolete: true
Attachment #750239 - Flags: review?(luke)
Attachment #750241 - Flags: review?(luke)
Comment on attachment 750241 [details] [diff] [review]
zap

Review of attachment 750241 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!  Yes, the emitter could use some further cleanup.  Btw, I recommend fuzzing before landing.

::: js/src/frontend/BytecodeEmitter.cpp
@@ +923,5 @@
>      return EmitAliasedVarOp(cx, op, pn, bce);
>  }
>  
> +static JSOp
> +GetIncDecInfo(ParseNodeKind kind, bool &post)

The usual SM style is to take outparams by *, not & (so that it is clear at the callsite).

@@ +1776,1 @@
>      pn2 = pn->maybeExpr();

Can haz ParseNode *pn2 = pn->maybeExpr()?
Attachment #750241 - Flags: review?(luke) → review+
Attached patch updated for fuzzing (obsolete) — Splinter Review
Fuzz please.
Attachment #750241 - Attachment is obsolete: true
Attachment #750838 - Flags: review+
Attachment #750838 - Flags: feedback?(gary)
Erk, here's an actually updated patch.
Attachment #750838 - Attachment is obsolete: true
Attachment #750838 - Flags: feedback?(gary)
Attachment #750839 - Flags: review+
Attachment #750839 - Flags: feedback?(gary)
Depends on: 873428
Comment on attachment 750839 [details] [diff] [review]
updated for fuzzing

Didn't find anything after a round of overnight fuzzing.
Attachment #750839 - Flags: feedback?(gary) → feedback+
Comment on attachment 750839 [details] [diff] [review]
updated for fuzzing

Nothing found here either within 24 hours of fuzzing :)
Attachment #750839 - Flags: feedback?(choller) → feedback+
https://hg.mozilla.org/mozilla-central/rev/4196d8b58814
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.