[webvtt] Update media/webvtt library to v0.5

RESOLVED FIXED in mozilla24

Status

()

Core
Audio/Video
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: caitp, Assigned: caitp)

Tracking

Trunk
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 750149 [details] [diff] [review]
Update WebVTT library to v0.5. r=rillian

Update webvtt parser to latest tagged revision (v0.5, aca1a4cc860141ea4759c87ecd906b365ffd89f0)

v0.5 includes the fixes backported in https://bugzilla.mozilla.org/show_bug.cgi?id=868629, making 868629 obsolete.

This release also includes preliminary support for the <lang> tag in WebVTT cuetext, and includes fixes to several bugs found in fuzz testing.
Attachment #750149 - Flags: review?(giles)
Pushed to try as https://tbpl.mozilla.org/?tree=Try&rev=8ccea332eed3
Comment on attachment 750149 [details] [diff] [review]
Update WebVTT library to v0.5. r=rillian

Review of attachment 750149 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits.

Please rebase now that bug 868629 has landed.

Please put the bug number in the first line of the commit message:

Bug 872822 - Update WebVTT library to v0.5. r=rillian

::: media/webvtt/update.sh
@@ +78,5 @@
>    hg addremove ${webvtt_dir}/
>  fi
> +
> +# apply patches
> +cd ${webvtt_dir}

Maybe have a '# patches go here' or '# no patches' comment here, so it's clear where to add them?
Attachment #750149 - Flags: review?(giles) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 750261 [details] [diff] [review]
Bug 872822 - Update WebVTT library to v0.5. r=rillian

Rebased, updated commit message and added comment to indicate where to add patches in media/webvtt/update.sh

Carrying forward previous r+ unless there is any other nits or incinerated try builds relating to these changes
Attachment #750149 - Attachment is obsolete: true
Attachment #750261 - Flags: review+
Thanks. https://hg.mozilla.org/integration/mozilla-inbound/rev/eff959d2842c
https://hg.mozilla.org/mozilla-central/rev/eff959d2842c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.