Finish adding editing mode to browser toolbar

RESOLVED FIXED in Firefox 26

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 26
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-fig)

Attachments

(1 attachment)

Filing this as a follow-up to bug 869494 to keep track of landing the last patch in there only on fig. This way, we can just close bug 869494 when the first 3 patches land on m-c.
The last patch in bug 869494 is pretty bitrotten on fig now... I'm working on updating it now, and I can post it again for review before landing it on fig.
Assignee: nobody → margaret.leibovic
Posted patch patchSplinter Review
I had to do quite a bit of unbitrotting to get lucasr's patch to apply to fig. I built with the patch, and it seems to work okay enough to land on fig, but I'd appreciate a quick once-over to make sure I didn't make any big mistakes. 

Because of the HomePager changes, the parts of the patch to animate showing/hiding about:home didn't apply at all, so I just decided to put on those with FIXMEs that we can fix in follow-up bugs :) Same thing for implementing filterEditingMode (lucasr already had a FIXME for that in AboutHome, but I decided to make it an even higher level FIXME, since I'm not sure what API we want to be using for that with HomePager).
Attachment #750552 - Flags: feedback?(sriram)
Attachment #750552 - Flags: feedback?(bnicholson)
I decided this is good enough to land, we can fix things in follow-ups:
https://hg.mozilla.org/projects/fig/rev/5d9bbd9db49f
Whiteboard: fixed-fig
Comment on attachment 750552 [details] [diff] [review]
patch

r=mfinkle can be found in bug 869494.
Attachment #750552 - Flags: feedback?(sriram)
Attachment #750552 - Flags: feedback?(bnicholson)
https://hg.mozilla.org/mozilla-central/rev/5d9bbd9db49f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.