872836 - Talos for win7 on iX slaves doesn't do the Windows-specific cleanup

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Phil Ringnalda (:philor)]

In http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#5641 we do some thrashing around to work around the frequent permission denied failures we get while trying to remove files on Windows.

Apparently win7 on iX doesn't match "if self.OS in ('xp', 'win7', 'w764')", since https://tbpl.mozilla.org/php/getParsedLog.php?id=22999804&full=1&branch=mozilla-inbound is an example of how those jobs just walk up to a slave and think they can say "nohup rm -rf *" and have it actually consistently work.

They are wrong, it won't consistently work. It's slightly more likely that the iX slaves are actually magical unicorns that will grant us each one wish on July 21st than that they will rm -rf without frequently failing.

Comment 1

[Armen [:armenzg]]

Attachment: add platforms to talos

Comment 2

[Armen [:armenzg]]

Live in production.

Comment 3

[Armen [:armenzg]]

Comment on attachment 751130 [details] [diff] [review]
add platforms to talos

This goes bad for Windows XP.

Comment 4

[Armen [:armenzg]]

Attachment: only cleanup win7-ix and win8-ix

I backed the original patch and I'm now landing it only for win7-ix, win8-ix.

I made a mistake when testing originally on staging and I manually fixed the machine. A newbie mistake. I thought I had picked up a wrong machine to test.

Comment 5

[Armen [:armenzg]]

Comment on attachment 751130 [details] [diff] [review]
add platforms to talos

I landed this patch in two times after all since I did not do the reconfig.
http://hg.mozilla.org/build/buildbotcustom/rev/ce0d3ddf7158
http://hg.mozilla.org/build/buildbotcustom/rev/f882535f6f35

I will reconfig in the morning after Q pushed that GPO change for us to the XP machines.

Comment 6

[Armen [:armenzg]]

Live in production.