872846 - Stop FrameNeedsReflow() calls for non-display SVG dirtying displayed ancestors

Status: NEW

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Right now when style changes etc. cause FrameNeedsReflow() to be called on descendants of non-display SVG, the dirty marking up the ancestor chain continues out of the non-display frames into the displayed frames, resulting in needless reflow work happening.

For example, when the font-size changes on a <tspan> in <text> in a <pattern>, nsStyleFont::CalcFontDifference is called under ReResolveStyleContext causing a restyle with the NS_STYLE_HINT_REFLOW hint. We end up in nsCSSFrameConstructor::ProcessRestyledFrames where StyleChangeReflow() is called for the tspan frame, which calls FrameNeedsReflow passing NS_FRAME_IS_DIRTY. That sets NS_FRAME_IS_DIRTY on the tspan and NS_FRAME_HAS_DIRTY_CHILDREN on its ancestors, most likely all the way up to the root frame.

We should stop FrameNeedsReflow from doing this.

Comment 1

[Jonathan Watt [:jwatt]]

We could solve this with a bit flag on nsSVGPatternFrame etc. which would make FrameNeedsReflow halt. Note that this would be slightly different to the NS_FRAME_REFLOW_ROOT flag, since we wouldn't actually want to add anything to PresShell::mDirtyRoots.

Comment 2

[Cameron McCormack (:heycam)]

Is this kind of like what I have currently in nsSVGTextFrame2::ScheduleReflowSVGNonDisplayText?

Comment 3

[Robert Longson [:longsonr]]

Attachment: Bug 872846 - Stop FrameNeedsReflow() calls for non-display SVG dirtying displayed ancestors r=emilio

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=e23fbbdb38161c82730887402ac4514c45f1712e