872864 - Intermittent browser_net_simple-request-data.js | The requestHeaders attachment has an incorrect |headers| property. - Got 6, expected 7 | browser_net_simple-request-details.js | There should be 13 header values displayed in this tabpanel. etc

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=23006345&tree=Mozilla-Central

Rev3 WINNT 6.1 mozilla-central pgo test mochitest-browser-chrome on 2013-05-15 18:39:51 PDT for push b30552dbb013
slave: talos-r3-w7-112

19:00:47     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-data.js | > Network events progress: 7/13, 0/0
19:00:47     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-data.js | There should be a requestHeaders attachment available.
19:00:47  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-data.js | The requestHeaders attachment has an incorrect |headers| property. - Got 6, expected 7
19:00:47     INFO -  Stack trace:
19:00:47     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 527
19:00:47     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-data.js :: <TOP_LEVEL> :: line 90
19:00:47     INFO -      JS frame :: resource://app/modules/devtools/shared/event-emitter.js :: <TOP_LEVEL> :: line 63
19:00:47     INFO -      JS frame :: resource://app/modules/devtools/shared/event-emitter.js :: EventEmitter_emit :: line 107
19:00:47     INFO -      JS frame :: chrome://browser/content/devtools/netmonitor-controller.js :: NetworkEventsHandler.prototype._onRequestHeaders :: line 390
19:00:47     INFO -      JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 623
19:00:47     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
19:00:47     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
19:00:47     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155
19:00:47     INFO -      JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 627
19:00:47     INFO -      JS frame :: chrome://global/content/devtools/dbg-transport.js :: <TOP_LEVEL> :: line 280
19:00:47     INFO -      JS frame :: chrome://global/content/devtools/dbg-transport.js :: <TOP_LEVEL> :: line 41
19:00:47     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | There should be 2 header scopes displayed in this tabpanel.
19:00:49  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | There should be 13 header values displayed in this tabpanel. - Got 12, expected 13
19:00:49     INFO -  Stack trace:
19:00:49     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 527
19:00:49     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js :: testHeadersTab :: line 67
19:00:49     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js :: <TOP_LEVEL> :: line 35
19:00:49     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120
19:00:49     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45
19:00:49     INFO -      JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 187
19:00:49     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_executeSoon/<.run :: line 556
19:00:49     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The empty notice should not be displayed in this tabpanel.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The response headers scope doesn't have the correct title.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The request headers scope doesn't have the correct title.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The first response header name was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The first response header value was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The second response header name was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The second response header value was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The third response header name was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The third response header value was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The last response header name was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The last response header value was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The first request header name was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The first request header value was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The penultimate request header name was incorrect.
19:00:49     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | The penultimate request header value was incorrect.
19:00:49     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | Console message: [JavaScript Warning: "Use of Mutation Events is deprecated. Use MutationObserver instead." {file: "chrome://browser/content/devtools/orion.js" line: 3408}]
19:00:56     INFO -  1368669656276	Services.DataReporting.Policy	DEBUG	Deletion request is scheduled for the future: Thu May 16 2013 18:48:43 GMT-0700 (Pacific Standard Time)
19:01:17  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | Test timed out
19:01:17     INFO -  args: ['C:\\talos-slave\\test\\build\\tests\\bin\\screenshot.exe', 'c:\\users\\cltbld\\appdata\\local\\temp\\mozilla-test-fail_h8cvwa']
19:01:18     INFO -  SCREENSHOT: <see log>
19:01:18     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | finish() was called, cleaning up...
19:01:18     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | finished in 30029ms
19:01:18  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | Found a tab after previous test timed out: http://example.com/browser/browser/devtools/netmonitor/test/sjs_simple-test-server.sjs
19:01:18     INFO -  NET-FRONTEND: Destroying the NetMonitorView
19:01:18     INFO -  NET-FRONTEND: Destroying the ToolbarView
19:01:18     INFO -  NET-FRONTEND: Destroying the SourcesView
19:01:18     INFO -  NET-FRONTEND: Destroying the SourcesView
19:01:18     INFO -  NET-FRONTEND: Destroying the NetMonitorView panes
19:01:18     INFO -  NET-FRONTEND: TargetEventsHandler is disconnecting...
19:01:18     INFO -  NET-FRONTEND: NetworkEventsHandler is disconnecting...
19:01:18     INFO -  TEST-INFO | checking window state

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 750288 [details] [diff] [review]
v1

Review of attachment 750288 [details] [diff] [review]:
-----------------------------------------------------------------

see comments.

::: browser/devtools/netmonitor/test/browser_net_simple-request-data.js
@@ +90,3 @@
>          "The requestHeaders attachment has an incorrect |headers| property.");
> +      // Can't test for an exact total number of headers, because it seems to
> +      // vary across pgo/non-pgo builds.

scary.

::: browser/devtools/netmonitor/test/browser_net_simple-request-details.js
@@ +118,5 @@
> +        is(lastReqHeaderName.getAttribute("value"),
> +          "Cache-Control", "The last request header name was incorrect.");
> +        is(lastReqHeaderValue.getAttribute("value"),
> +          "\"max-age=0\"", "The last request header value was incorrect.");
> +      }

we'll be hiding failures if either of those return null. Not sure that's a great fix for this.

Could use a comment to explain why we're doing this with bug number.

also, maybe include an else block with an info message so we can at least track this.

Comment 3

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=23053325&tree=Mozilla-Central
Rev5 MacOSX Mountain Lion 10.8 mozilla-central opt test mochitest-browser-chrome on 2013-05-16 15:09:13
slave: talos-mtnlion-r5-037

15:24:41  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-data.js | The requestHeaders attachment has an incorrect |headers| property. - Got 6, expected 7
15:24:42  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | There should be 13 header values displayed in this tabpanel. - Got 12, expected 13
15:25:11  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | Test timed out
15:25:14  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-request-details.js | Found a tab after previous test timed out: http://example.com/browser/browser/devtools/netmonitor/test/sjs_simple-test-server.sjs

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #2)
> 
> we'll be hiding failures if either of those return null. Not sure that's a
> great fix for this.
> 

I wouldn't be entirely worried about hiding failures. Headers are extensively tested in the webconsole backend (and frontend iirc). These checks are mostly about their presentation in the netmonitor's sidemenu.

> Could use a comment to explain why we're doing this with bug number.
> Also, maybe include an else block with an info message so we can at least
> track this.

Definitely both great ideas! Will update.

Comment 5

[Victor Porof [:vporof][:vp]]

Addressed comments and landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab40846d1446

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab40846d1446