Closed
Bug 872893
Opened 11 years ago
Closed 11 years ago
make EmitElemOp static
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: Benjamin, Assigned: Benjamin)
Details
Attachments
(1 file)
1.62 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
For some reason unknown to me, EmitElemOp of BytecodeEmitter.cpp is exported through Parser.h. It doesn't need to be.
Assignee | ||
Comment 1•11 years ago
|
||
r?bhackett since this seems to be from bug 835587.
Attachment #750274 -
Flags: review?(bhackett1024)
Comment 2•11 years ago
|
||
Comment on attachment 750274 [details] [diff] [review] make it static Review of attachment 750274 [details] [diff] [review]: ----------------------------------------------------------------- I think this code was because I initially tried to make Parser::handler a private member in bug 835587, but that ended up not working out.
Attachment #750274 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc82b5b592d
Assignee: general → benjamin
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4dc82b5b592d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•