Closed
Bug 872906
Opened 12 years ago
Closed 12 years ago
Calls from JS served from file:// urls are greyed out
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: harth, Assigned: gl)
Details
(Whiteboard: [mentor=anton@mozilla.com] [good-first-bug])
Attachments
(2 files)
913 bytes,
patch
|
anton
:
review+
|
Details | Diff | Splinter Review |
1.00 KB,
patch
|
anton
:
review+
|
Details | Diff | Splinter Review |
When I run a site from a file url, all the function calls are greyed out in the Profiler. If I serve it up, only the browser calls are greyed out.
Updated•12 years ago
|
Assignee: nobody → anton
Priority: -- → P2
Updated•12 years ago
|
Assignee: anton → nobody
Updated•12 years ago
|
Whiteboard: [mentor=anton@mozilla.com] [good-first-bug]
Updated•12 years ago
|
Priority: P2 → P3
Assignee | ||
Comment 1•12 years ago
|
||
Hi Anton, I would like to tackle this bug. I have checked out the source for mozilla-central and built a debuggable instance of firefox. I will be looking into how to debug the profiler tomorrow.
Comment 2•12 years ago
|
||
Thanks! Let me know if you have any questions. This is mostly a Cleopatra issue I suspect. We grey out all sources that start with `otherhost_` and I assume Cleopatra thinks that `file://` URLs are `otherhost_` as well. Files you'll probably need to look at: devtools.css, devtools.js, cleopatra/js/parser.js and cleopatra/js/parserWorker.js.
Assignee | ||
Comment 3•12 years ago
|
||
Cool! I will work on it this Friday and be on irc. Hope to have the fix soon.
Comment 4•12 years ago
|
||
It seems like Gabriel has abandoned this defect. If this is the case, I would gladly take it over. Thanks.
Assignee | ||
Comment 5•12 years ago
|
||
Sorry, I have been busy, but I actually have a patch for this bug that I was gonna post up after work.
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #787646 -
Flags: review?(anton)
Assignee | ||
Comment 7•12 years ago
|
||
So, Anton's assumptions were correct. There were no cases that caught the 'file://' protocol and it fell into 'otherhost_' which are grey out as a result of the defined style in devtools.css
My fix was to simply catch sources with 'file://' protocol and generate a new resource for them similar to what is done with 'http://'. Debugging the profiler was a neat and lengthy experience.
Updated•12 years ago
|
Attachment #787646 -
Flags: review?(anton) → review+
Comment 8•12 years ago
|
||
LGTM. Added [land-in-fx-team] tag so that I won't forget to land it soon. Thanks!
Whiteboard: [mentor=anton@mozilla.com] [good-first-bug] → [mentor=anton@mozilla.com] [good-first-bug][land-in-fx-team]
Assignee | ||
Comment 9•12 years ago
|
||
Refreshed patch to include author and commit message
Assignee | ||
Updated•12 years ago
|
Attachment #788492 -
Flags: review?(anton)
Comment 10•12 years ago
|
||
Comment on attachment 788492 [details] [diff] [review]
Refreshed patch to include author and commit message
Review of attachment 788492 [details] [diff] [review]:
-----------------------------------------------------------------
When you change a reviewed patch without changing any code in it you don't need to ask for another review—you can just carry over previous r+. I'm building a fresh Nightly right now, will land this patch once it's done.
Attachment #788492 -
Flags: review?(anton) → review+
Assignee | ||
Comment 11•12 years ago
|
||
Okay thanks Anton!
Comment 12•12 years ago
|
||
Whiteboard: [mentor=anton@mozilla.com] [good-first-bug][land-in-fx-team] → [mentor=anton@mozilla.com] [good-first-bug][fixed-in-fx-team]
Comment 13•12 years ago
|
||
Landed in fx-team, should be merged into mozilla-central and released as Nightly within a couple of days. Thanks Gabriel!
Comment 14•12 years ago
|
||
Assignee: nobody → gabriel.luong
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=anton@mozilla.com] [good-first-bug][fixed-in-fx-team] → [mentor=anton@mozilla.com] [good-first-bug]
Target Milestone: --- → Firefox 26
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•