If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Reader Mode text formatting pop-up is incorrectly positioned on device rotation

VERIFIED FIXED in Firefox 24

Status

()

Firefox for Android
Reader View
VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: AdrianT, Assigned: Margaret)

Tracking

Trunk
Firefox 24
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox22 affected, firefox23 affected, firefox24 verified, fennec+)

Details

(Whiteboard: [testday-20130726])

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 750343 [details]
screenshot

Aurora 23.0a2 2013-05-15/ Nightly 24.0a1 2013-05-15
HTC Desire Z (Android 2.3.3) / Samsung Galaxy S2 (Android 4.0.3)

Steps to reproduce:
1) Open any content in Reader Mode
2) With the device in Portrait open the text formatting pop-up
3) Rotate the device to Landscape mode

Expected results:
The text formatting pop-up is pinned to the text formatting button

Actual results:
The text formatting pop-up is positioned pinned to the Reading List button not the text formatting button
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → +
(Assignee)

Comment 1

5 years ago
Created attachment 751840 [details] [diff] [review]
Wait for reflow before calculating position of text style popup menu

The problem here is that when we call updatePopupPosition() immediately on the "resize" event, we get old values for the toggle button's offsetWidth/offsetLeft. Wrapping the call in a setTimeout fixes this.
Attachment #751840 - Flags: review?(lucasr.at.mozilla)
(Assignee)

Comment 2

5 years ago
Created attachment 751845 [details] [diff] [review]
(Part 2) Fix indentation
Attachment #751845 - Flags: review?(lucasr.at.mozilla)

Updated

5 years ago
Attachment #751840 - Flags: review?(lucasr.at.mozilla) → review+
(In reply to :Margaret Leibovic from comment #1)
> Created attachment 751840 [details] [diff] [review]
> Wait for reflow before calculating position of text style popup menu
> 
> The problem here is that when we call updatePopupPosition() immediately on
> the "resize" event, we get old values for the toggle button's
> offsetWidth/offsetLeft. Wrapping the call in a setTimeout fixes this.

Actually, could you please add a comment explaining the intent of this setTimeout()?
Comment on attachment 751845 [details] [diff] [review]
(Part 2) Fix indentation

Review of attachment 751845 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #751845 - Flags: review?(lucasr.at.mozilla) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e8f4093d912
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fda32fc082c
https://hg.mozilla.org/mozilla-central/rev/2e8f4093d912
https://hg.mozilla.org/mozilla-central/rev/2fda32fc082c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24

Updated

5 years ago
status-firefox24: affected → fixed
Verified fixed on:
Build: Firefox for Android 24.0a1(2013-06-20)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1
status-firefox24: fixed → verified

Comment 8

4 years ago
I can verify this is fixed in a Galaxy S2 phone with Android 4.0.3 and the latest Aurora build
Whiteboard: [testday-20130726]

Updated

4 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.