B2G: Hamachi has a mismatch version of hardware/ril

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: allstars.chh, Assigned: mwu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

From hamachi, the commit of the hardware/ril is 86ddf397767be35acc8d625ade69767189a17d61.

But jaoo has reported that some error happened in libril 
see log http://www.pastebin.mozilla.org/2409429

doing grep ril.cpp, I saw the error message is from responseSimStatus,
and the reason for that error is the responselen is not matched sizeof(RIL_CardStatus_v6) nor sizeof(RIL_CardStatus_v5)

So it seems Hamachi uses a different version of ril with the modem. 
And causes the libril failed in the response of GET_SIM_STATUS.
Summary: Hamachi has a mismatch version of hardware/ril → B2G: Hamachi has a mismatch version of hardware/ril
Assignee

Comment 1

6 years ago
jhford - Could we get the hamachi/leo v1-train manifests updated to the latest b2g/ics_chocolate branches?

I think we need to either increase the frequency of these updates or just drop the hardcoding for hamachi/leo - I'm not sure if it's doing us much good here.
Assignee

Updated

6 years ago
Flags: needinfo?(jhford)
(In reply to Michael Wu [:mwu] from comment #1)
> jhford - Could we get the hamachi/leo v1-train manifests updated to the
> latest b2g/ics_chocolate branches?
> 
> I think we need to either increase the frequency of these updates or just
> drop the hardcoding for hamachi/leo - I'm not sure if it's doing us much
> good here.

I'll update these.  As for removing the hardcodes, are our partners using the lastest head of ics_chocolate in their builds, and are they b2g specific branches?
Flags: needinfo?(jhford)
Assignee

Comment 3

6 years ago
Our partners update to the latest every so often. b2g/ics_strawberry and b2g/ics_strawberry_v1 are b2g specific, so devices based on those branches are ok to stop hard coding for. ics_chocolate based devices are a little less safe, so we can stop hardcoding for just the strawberry devices (hamachi and leo) right now.
Assignee

Updated

6 years ago
Blocks: 880331
Assignee

Comment 4

6 years ago
jhford - this is blocking a leo blocker. Do you have time to deal with it soon? I'll fix it if you don't have time.
Assignee

Updated

6 years ago
Flags: needinfo?(jhford)
With comment 3, I have the information I need for this.  I'll do this now.
Flags: needinfo?(jhford)

Updated

6 years ago
Blocks: 877757
Assignee

Comment 7

6 years ago
Going to fix a small issue with that push request and land it.
Assignee: nobody → mwu
You need to log in before you can comment on or make changes to this bug.