873039 - Cleaning update directory should be changed from CleanUpdatesDir to CleanUpdateDirectories for Thunderbird

Status: RESOLVED DUPLICATE of bug 1336804

(Thunderbird :: Installer, defect)

Description

[Brian R. Bondy [:bbondy]]

In Windows, the update directory was changed to be a subdirectory of C:\Users\Brian\AppData\Local\Mozilla\updates based on the taskbarIDs value for the install path.

See bug 572162 for more information.

CleanUpdatesDir is obsolete and will clear the old update directory only.
CleanUpdateDirectories should be used instead now.

Comment 1

[Magnus Melin [:mkmelin]]

http://mxr.mozilla.org/comm-central/search?string=CleanUpdatesDir
http://mxr.mozilla.org/comm-central/search?string=CleanUpdateDirectories

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Straight port of the m-c patch. Try server build here: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=fd5445ececd6

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 781023 [details] [diff] [review]
The fix

I copied and pasted this badly.

Comment 4

[Mark Banner (:standard8)]

Brian, I'm confused, I've just checked on latest Daily update, and we're still storing updates in:

C:\Users\Brian\AppData\Local\Thunderbird\Daily\updates\

Is this because we're not specifying the vendor id?

So I'm not actually sure we need to do this change for TB at the moment.

Comment 5

[Brian R. Bondy [:bbondy]]

I think you may be missing the TaksbarIds entry, see:
http://dxr.mozilla.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.cpp#l1008

Comment 6

[Brian R. Bondy [:bbondy]]

and 
http://dxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/installer.nsi#l211

Comment 7

[Mark Banner (:standard8)]

(In reply to Brian R. Bondy [:bbondy] from comment #5)
> I think you may be missing the TaksbarIds entry, see:
> http://dxr.mozilla.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.
> cpp#l1008

Hmm, yes, that would be because Thunderbird doesn't have the vendor field specified (which isn't possible atm).

Comment 8

[Mark Banner (:standard8)]

Not working on this atm. I think there would need to be some investigation as to what's required as per Brian's comments.

Comment 9

[Wayne Mery (:wsmwk)]

This may be wanted for 64bit

Comment 10

[Richard Marti (:Paenglab)]

We updated the installer in bug 1336804 there we use CleanUpdateDirectories like FX does. Marking as dupe.