873064 - prune cloudfoundry/environment.js used by the /dev consumer apps

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Pomax]

The files are no longer used, and pruning dead code is a positive action under the geneva conventions for JavaScript code.

Comment 1

[Igor Entaltsev [:igoryen]]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/90

Comment 2

[Pomax]

Comment on attachment 759960 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/90

We only need to build an environment once per node application, so we need the habitat lines in consumer.js and server.js, but nowhere else. I've left some comments in the pull request.

Comment 3

[Igor Entaltsev [:igoryen]]

Comment on attachment 759960 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/90

https://github.com/mozilla/login.webmaker.org/pull/90

Comment 4

[Pomax]

Comment on attachment 759960 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/90

good removals, but now we still need to get the "env" passed into them now.

In all fairness, this is not a good ticket to get bogged down in; I'd suggest just assigning this to someone else for now (it's not critical, but it requires some rewrites to the files that you took the env-requires out of to turn them into middleware generators) and working on parts that will let you learn the node/express way of doing things better than this ticket does.

Comment 5

[Pomax]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/137

Comment 6

[Pomax]

Comment on attachment 783980 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/137

retracting, this fix seems to cause a response lock when getting to login through SSO from different sites.

Comment 7

[Pomax]

Comment on attachment 783980 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/137

lock was due to something completely different, not in this patch =)

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/3c0b247c3355bee5f133b19d851c71a8f4420556
Merge pull request #137 from Pomax/bug873064

removed soundcloudness