prune cloudfoundry/environment.js used by the /dev consumer apps

RESOLVED FIXED

Status

Webmaker
Login
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pomax, Assigned: pomax)

Tracking

Details

(Whiteboard: s=20130729 p=1)

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
The files are no longer used, and pruning dead code is a positive action under the geneva conventions for JavaScript code.
(Assignee)

Updated

5 years ago
Assignee: nobody → pomax
Assignee: pomax → igor.yentaltsev
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Comment on attachment 759960 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/90

We only need to build an environment once per node application, so we need the habitat lines in consumer.js and server.js, but nowhere else. I've left some comments in the pull request.
Attachment #759960 - Flags: review?(pomax) → review-
(Assignee)

Comment 4

5 years ago
Comment on attachment 759960 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/90

good removals, but now we still need to get the "env" passed into them now.

In all fairness, this is not a good ticket to get bogged down in; I'd suggest just assigning this to someone else for now (it's not critical, but it requires some rewrites to the files that you took the env-requires out of to turn them into middleware generators) and working on parts that will let you learn the node/express way of doing things better than this ticket does.
Attachment #759960 - Flags: review?(pomax) → review-
(Assignee)

Updated

5 years ago
Assignee: igor.yentaltsev → pomax
(Assignee)

Updated

5 years ago
Whiteboard: c=login → s=20130729 p=1
(Assignee)

Comment 5

5 years ago
Created attachment 783980 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/137
Attachment #783980 - Flags: review?(kieran.sedgwick)
(Assignee)

Comment 6

5 years ago
Comment on attachment 783980 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/137

retracting, this fix seems to cause a response lock when getting to login through SSO from different sites.
Attachment #783980 - Flags: review?(kieran.sedgwick) → review-
(Assignee)

Comment 7

5 years ago
Comment on attachment 783980 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/137

lock was due to something completely different, not in this patch =)
Attachment #783980 - Flags: review- → review?(kieran.sedgwick)
Attachment #783980 - Flags: review?(kieran.sedgwick) → review+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.