873132 - Deep-linking of ratings add page results in JS errors when signed out

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Stuart Colville [:muffinresearch]]

STR:

* Log-out
* Visit https://marketplace-dev.allizom.org/app/twitter/ratings/add

Results:
 
* TypeError: navigator.id is undefined
* TypeError: z.context is undefined
* Splash screen stays open.

What should happen:

* Page should open after logging in

Comment 1

[Matt Basta [:basta]]

This issue will go away after 6/5.

This is happening because we load Persona asynchronously, and the builder fires off the view initialization before navigator.id exists. The view tries to use login.login(), which fails.

After 6/5, we won't need to conditionally load Persona and we can just put their include.js before ours with some clever `defer` and `async` attributes. The problem will simply go away after that.

Comment 2

[Stuart Colville [:muffinresearch]]

This commit should also prevent deeplinking add/edit when signed out as it will navigate back to the app page. https://github.com/mozilla/fireplace/commit/949d1dfb231cb36200d0235eedcfd550f46bf098

Comment 3

[Matt Basta [:basta]]

This should be fixed now that we load Persona before our own JS.