Open
Bug 873205
Opened 12 years ago
Updated 3 years ago
Cleanup nsWebBrowserPersist::OnWalkDOMNode
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
NEW
People
(Reporter: dzbarsky, Unassigned)
Details
Attachments
(1 file)
|
9.35 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #750612 -
Flags: review?(Ms2ger)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 750612 [details] [diff] [review]
Patch
Review of attachment 750612 [details] [diff] [review]:
-----------------------------------------------------------------
I like the idea, but I'm not going to review outside DOM, sorry.
::: embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp
@@ +2698,4 @@
> }
>
> nsCOMPtr<nsIContent> content = do_QueryInterface(aNode);
> + if (!content || !content-IsElement())
I don't think so :)
Attachment #750612 -
Flags: review?(Ms2ger)
|
Reporter | |
Updated•12 years ago
|
Attachment #750612 -
Flags: review?(benjamin)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 750612 [details] [diff] [review]
Patch
Is there any test coverage of this code? I'm owner in name but not familiar with this code at all.
|
|
||
Updated•12 years ago
|
Attachment #750612 -
Flags: review?(benjamin)
|
|
||
Comment 3•9 years ago
|
||
Per smaug, we're going to put webbrowserpersist bugs in Document Navigation.
Component: Embedding: APIs → Document Navigation
|
||
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•